Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cpl_scalars #794

Merged
merged 18 commits into from
Apr 3, 2024
Merged

Conversation

DeniseWorthen
Copy link
Collaborator

Description

Add the scalar field names cpl_scalars to the export state of FV3. This will enable FV3 to sent to CMEPS the 3 dimensions of either a CSG or Regional domain. For the CSG, the indices of the scalar field will contain the nx,ny and number of tiles.

Issue(s) addressed

Testing

During development, the full RT was run with and w/o the accompanying changes in CMEPS (ESCOMP/CMEPS#436) and all baselines were B4B. When the required changes are made in ufs.configure, 3 tests will change baselines in the compared mediator history files only.

Full testing will be logged in the accompanying UWM PR.

Dependencies

The accompanying CMEPS PR will first need to be tested at ESCOMP.

@DusanJovic-NOAA DusanJovic-NOAA changed the title enable cpl_scalars Enable cpl_scalars Mar 8, 2024
@DeniseWorthen DeniseWorthen marked this pull request as ready for review March 13, 2024 17:57
@zach1221 zach1221 requested a review from jkbk2004 April 3, 2024 19:16
@zach1221
Copy link
Collaborator

zach1221 commented Apr 3, 2024

@DusanJovic-NOAA could you please resolve the above open conversations?
@jkbk2004 I have sent you a final review.

@jkbk2004 jkbk2004 merged commit 1cac9d3 into NOAA-EMC:develop Apr 3, 2024
0 of 2 checks passed
zhanglikate added a commit to zhanglikate/fv3atm that referenced this pull request May 3, 2024
commit da95cc4
Author: WenMeng-NOAA <[email protected]>
Date:   Fri Apr 19 12:36:43 2024 -0400

    Update upp submodule (NOAA-EMC#811)

    * Update github workflow. Update gcc to 12 and mpi to openmpi

    * Add 'spack clean' to reduce the size of the cache files

    * Split GCC.yml workflow into two jobs, build_spack and build_fv3atm

    * Update github workflow. Add mpich

    * Update github actions to v4

    * Use action/cache/restore in build_fv3atm job

    * update upp revision to 5faac75

    * Update GCC.yml

    ---------

    Co-authored-by: Dusan Jovic <[email protected]>

commit 979bcab
Author: Dusan Jovic <[email protected]>
Date:   Wed Apr 17 13:42:06 2024 -0400

    Update dycore to remove compiler warnings (NOAA-EMC#813)

    * Update atmos_cubed_sphere and add compile definition BYPASS_BREED_SLP_INLINE to dycore

    * Pass correct mpi communicator type to post_alctvars routine in inline post

commit 37e7d48
Author: Samuel Trahan (NOAA contractor) <[email protected]>
Date:   Sun Apr 14 13:00:07 2024 -0400

    bug fixes: kchunk3d ignored, hailwat uninitialized in dycore, tile_num wrong for nests (NOAA-EMC#806)

    * nesting fixes
    1. Initialize hailwat index in dynamical core.
    2. Use the correct tile number for nests in atmos_model.F90.

    * remove unneeded write statements

    * Fix kchunk3d in io/module_write_netcdf.F90

    ---------

    Co-authored-by: Dusan Jovic <[email protected]>

commit 383687e
Author: JONG KIM <[email protected]>
Date:   Thu Apr 4 16:34:52 2024 -0400

    cubed_sphere hash fix to f060e85 (NOAA-EMC#817)

    * Update cubed_sphere@f060e85 hash: a bug fix in the HAILCAST diagnostic code (units issue)

commit 1cac9d3
Author: Denise Worthen <[email protected]>
Date:   Wed Apr 3 16:48:31 2024 -0400

    Enable cpl_scalars (NOAA-EMC#794)

    * add cpl_scalars for atm

    * add field cpl_scalars to export state of fv3atm when coupled.
    cpl_scalars contain the dimensions of the fv3atm domain and are
    used by cmeps to write mediator history files as a single 2d
    grid for regional and 6 2d grids for CSG.

    * remove unused NUOPC use statement

commit 1b75fe2
Author: Dusan Jovic <[email protected]>
Date:   Mon Apr 1 17:12:08 2024 -0400

    Update module_write_netcdf to avoid hangs in RRFS runs (NOAA-EMC#803)

    * Split add_dim into two routines

    * Add NF90_NODIMSCALE_ATTACH constant

    * Test classic netcdf file formats

commit 1ba8410
Author: lisa-bengtsson <[email protected]>
Date:   Wed Mar 27 12:12:00 2024 -0600

    Introduce namelist flag xr_cnvcld to control if suspended grid-mean convective cloud condensate should be included in cloud fraction and optical depth calculation in radiation in the GFS suite. (NOAA-EMC#799)

    * Update ccpp/physics for namelist flag xr_cnvcld
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable cpl_scalars in coupled model for CSG and regional domains
4 participants