Submodule pointer updates for ccpp-framework and ccpp-physics, fix compile error on macOS #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…review and testing
…ture/chunked_array_support
…ture/chunked_array_support
climbfuji
changed the title
climbfuji
changed the title
14 tasks
DusanJovic-NOAA
approved these changes
Dec 29, 2023
…ture/chunked_array_support
…ture/chunked_array_support
…ture/chunked_array_support
…ture/chunked_array_support
|
@climbfuji I think that CCPP submodules have been merged, so please update the pointers and .gitmodules in prep for merge. |
Thanks, done! |
|
@jkbk2004 this PR is ready for final review |
jkbk2004
approved these changes
Feb 23, 2024
zach1221
pushed a commit
to ufs-community/ufs-weather-model
that referenced
this pull request
Feb 23, 2024
…run compile jobs of regression test suite only & -mcmodel=medium gnu.cmake option (also includes #2142) (#2066) * UFSWM - Add option to `rt.sh` to run compile-only tests * FV3 - Update submodule pointer (NOAA-EMC/fv3atm#747) * ccpp-physics - Update submodule pointer (ufs-community/ccpp-physics#150) * ccpp-framework - Update submodule pointer (NCAR/ccpp-framework#519) * Update WM license and documentation logo * Update GNU.cmake: -mcmodel=medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the submodule pointers for ccpp-framework and ccpp-physics for the changes described in NCAR/ccpp-framework#519 (ccpp_prebuild.py: add support for chunked arrays) and ufs-community/ccpp-physics#150 (ufs-community/ccpp-physics#150).
The ccpp-framework PR adds a new capability which is not yet used in the ufs-weather-model. The changes are 100% backward compatible and initial regression testing on Hera with Intel and GNU showed that there are no changes to the baselines.
The ccpp-physics PR fixes an issue (non-CCPP compliant code that was added recently).
Finally, a small change is included that fixes compiling recent fv3atm code on macOS (see #745).
Thus, this PR is mostly an update to prepare for future changes to the way fv3atm allocates data used by the physics, with the expectation that the code is going to be simpler and that it will be at least as performant as the current code.
Issue(s) addressed
Resolves #745
Working towards #748 (step 1)
Testing
See NCAR/ccpp-framework#519 and ufs-community/ufs-weather-model#2066
Dependencies
This PR is part of a set of PRs that need to be tested and merged together: