Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ww3 homp #1149

Draft
wants to merge 24 commits into
base: develop
Choose a base branch
from
Draft

Ww3 homp #1149

wants to merge 24 commits into from

Conversation

aronroland
Copy link
Collaborator

Pull Request Summary

Hybrid OpenMP for UG

Description

This pull request implements Hybrid OpenMP for UG-Schemes.

Please also include the following information:

  • Add any suggestions for a reviewer
    new feature
  • Are answer changes expected from this PR? Please describe the changes and the reason why in addition to which of the following labels would apply: mod_def change, out_grd change, out_pnt change, restart file change, Regression test
    No

Issue(s) addressed

none

Commit Message

OMPH for UGRID

Check list

  • Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
  • Checked the checklist for a developer submitting to develop.
  • If a version number update is required, checked the updating version number checklist.
  • If a new feature was added, a regression test for testing the new feature is added.
    tp2.6 was tested, certain regtests have to be designed yet.

Testing

  • How were these changes tested?
    tp2.6 war run with various settings
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    I made a new regression test needs to be added to the suite.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
    Will do that with ERDC
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
    to be done ...
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    to be done ...

@MatthewMasarik-NOAA
Copy link
Collaborator

@aronroland @thesser1 It's really great to see all this new work coming in! Can we expect the testing results soon as well? Please keep us posted on your progress so we know when we can start to review on our end.

@aronroland
Copy link
Collaborator Author

yes, sir we do our best

@MatthewMasarik-NOAA
Copy link
Collaborator

Sounds good. Thank you, Aron

FLUSH(740+IAPROC)
#endif

#ifdef W3_O MPH
Copy link
Collaborator

@ukmo-ccbunney ukmo-ccbunney Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aronroland - just spotted this potential typo?
Should this be W3_OMPH, not W3_O MPH?

Or was it deliberate to disable that OMP directive?

@JessicaMeixner-NOAA
Copy link
Collaborator

@aronroland I'm going to mark this as a draft. Please mark it as ready to review when it's time and testing information is available.

@JessicaMeixner-NOAA JessicaMeixner-NOAA marked this pull request as draft January 16, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants