-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WW3 2dm File Format #1148
base: develop
Are you sure you want to change the base?
WW3 2dm File Format #1148
Conversation
…ndary for gr3 files
…solver have been forgotten to merge by me. The solver conevergence computation have not been good before due to the choosen accuracies.
@aronroland since this is from the ERDC fork, we are expecting regression test information before we start review and testing on this PR. I did notice that you have deleted the ufs1.2 regression test. Was this intentional? I don't see any mention of it in the PR description. |
for sure not by purpose i did actually nothing on the regtests ... hmmm strange ....--Sent from my Android phone with GMX Mail. Please excuse my brevity.On 12/19/23, 2:31 PM Jessica Meixner ***@***.***> wrote:
@aronroland since this is from the ERDC fork, we are expecting regression test information before we start review and testing on this PR. I did notice that you have deleted the ufs1.2 regression test. Was this intentional? I don't see any mention of it in the PR description.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@aronroland no worries, we'll just want to make sure that regression test is added back before we proceed with this PR. |
…generate boundary conditions ...
…hris and others
Converting to draft. Please mark as ready for review after testing information is available. |
Conflicts: model/src/w3wavemd.F90
Pull Request Summary
Add alternative File Format for the use of WW3 by ERDC. This is the native SMS format called *.2dm.
Description
Beside the new format, active boundary and Neuman type boundary conditions can be prescribed in the meshbnd.2dm file. The file name is yet default.
Please also include the following information:
none
new feature
None, but a new regression test was designed. Needs to be discussed.
-->
Issue(s) addressed
none
Commit Message
Add 2dm file format for unstructured grids.
Check list
Will be discussed these days
Testing
In a new regtest based on tp2.6.
Yes, see above.
No
None expected.
Will be done ...