Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modulefiles for Orion after Rocky 9 switch #86

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

SamuelDegelia-NOAA
Copy link
Contributor

@SamuelDegelia-NOAA SamuelDegelia-NOAA commented Jun 20, 2024

This PR modifies RDASApp/modulefiles/orion.intel.lua for required changes after the Orion OS was switched from CentOS 7 to Rocky 9. This follows the updates in GDASApp PR #1180 (thanks @RussTreadon-NOAA). After updating the modules, all exes build successfully and the rrfs-test ctests pass:

(base) orion-login-2[33] sdegelia$ module use RDASApp/modulefiles
(base) orion-login-2[34] sdegelia$ module load RDAS/orion.intel
(gdasapp) orion-login-2[35] sdegelia$ cd RDASApp/build/rrfs-test/
(gdasapp) orion-login-2[37] sdegelia$ ctest
Test project /work/noaa/wrfruc/sdegelia/RDASApp_rocky/RDASApp/build/rrfs-test
    Start 1: rrfs_fv3jedi_hyb_2022052619
1/5 Test #1: rrfs_fv3jedi_hyb_2022052619 ............   Passed  201.92 sec
    Start 2: rrfs_fv3jedi_letkf_2022052619
2/5 Test #2: rrfs_fv3jedi_letkf_2022052619 ..........   Passed   63.20 sec
    Start 3: rrfs_mpasjedi_2022052619_Ens3Dvar
3/5 Test #3: rrfs_mpasjedi_2022052619_Ens3Dvar ......   Passed   75.52 sec
    Start 4: rrfs_mpasjedi_2022052619_atms_npp_qc
4/5 Test #4: rrfs_mpasjedi_2022052619_atms_npp_qc ...   Passed  130.87 sec
    Start 5: rrfs_mpasjedi_2022052619_letkf
5/5 Test #5: rrfs_mpasjedi_2022052619_letkf .........   Passed   81.59 sec

100% tests passed, 0 tests failed out of 5

Label Time Summary:
mpi            = 553.09 sec*proc (5 tests)
rdas-bundle    = 553.09 sec*proc (5 tests)
script         = 553.09 sec*proc (5 tests)

Total Test time (real) = 553.16 sec

A couple of notes:

  1. Loading the modulefiles gives the warning: The following dependent module(s) are not currently loaded: py-numpy/1.22.3 (required by: bufr/12.0.1), python/3.10.13 (required by: boost/1.83.0, bufr/12.0.1, fckit/0.11.0, atlas/0.35.1, py-pybind11/2.11.0). Everything still builds successfully but perhaps something to keep an eye on in the future.
  2. I also tested running the eva tools and the associated modules in RDASApp/modulefiles/EVA/orion.lua and everything works without any changes there.

@ShunLiu-NOAA
Copy link

@SamuelDegelia-NOAA Thank you for this update.

@TingLei-NOAA
Copy link
Contributor

@SamuelDegelia-NOAA Thanks for taking care of this. After this upgrading, are rdasapp and gdasapp using different modules or still the same , the former's could be regarded as a duplicate of the latter?

@SamuelDegelia-NOAA
Copy link
Contributor Author

@TingLei-NOAA Yes rdasapp and gdasapp are using the same modules again after this PR. These updates follow a PR made to the corresponding orion modulefile for gdasapp.

@TingLei-NOAA
Copy link
Contributor

@SamuelDegelia-NOAA Thanks for the clarification. I 'd also recommend to explicitly give a link pointing to the gdasapp pr which you mentioned.
That is great you tested this new setup.

@SamuelDegelia-NOAA
Copy link
Contributor Author

@SamuelDegelia-NOAA Thanks for the clarification. I 'd also recommend to explicitly give a link pointing to the gdasapp pr which you mentioned. That is great you tested this new setup.

Good call - I just updated the main post to include the GDASApp PR.

@ShunLiu-NOAA ShunLiu-NOAA merged commit c689636 into develop Jun 20, 2024
3 checks passed
@ShunLiu-NOAA ShunLiu-NOAA deleted the feature/update_orion_rocky branch June 20, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Orion modules for switch from CentOS 7 to Rocky 9
4 participants