Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for zero total ozone pressure in EnKF (issue #625) #626

Merged
merged 37 commits into from
Sep 22, 2023
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
8b8673e
GitHub Issue NOAA-EMC/GSI#2 merge release/gfsda.v16.0.0 at 1d3e30a i…
RussTreadon-NOAA Oct 15, 2020
c988929
Merge remote-tracking branch 'upstream/master'
jswhit2 Nov 6, 2020
87946df
merge from upstream master
jswhit2 Nov 6, 2020
61b5da6
Merge remote-tracking branch 'upstream/master'
jswhit2 Nov 24, 2020
605cc9d
Merge remote-tracking branch 'upstream/master'
jswhit2 Dec 24, 2020
7548c9e
Merge remote-tracking branch 'upstream/master'
jswhit2 Jan 21, 2021
e7e0320
Merge remote-tracking branch 'upstream/master'
jswhit2 Mar 11, 2021
2790e5f
Merge remote-tracking branch 'upstream/master'
jswhit2 Apr 27, 2021
86a548a
Merge branch 'NOAA-EMC:master' into master
jswhit May 19, 2021
9c731e2
Merge remote-tracking branch 'upstream/master'
jswhit2 Jun 24, 2021
11fba4f
Merge remote-tracking branch 'upstream/master'
jswhit2 Jul 15, 2021
f471641
Merge remote-tracking branch 'upstream/master'
jswhit2 Jul 28, 2021
7d84c64
Merge remote-tracking branch 'upstream/master'
jswhit2 Aug 18, 2021
e5c4d53
Merge remote-tracking branch 'upstream/master'
jswhit2 Aug 26, 2021
7fff4ac
Merge remote-tracking branch 'upstream/master'
jswhit2 Sep 10, 2021
212e3dd
Merge remote-tracking branch 'upstream/master'
jswhit2 Oct 8, 2021
da004e0
Merge remote-tracking branch 'upstream/master'
jswhit2 Nov 10, 2021
8a6641b
Merge branch 'NOAA-EMC:master' into master
jswhit Nov 10, 2021
a297111
remove unneeded files
jswhit2 Nov 10, 2021
dbc7ad4
Merge remote-tracking branch 'upstream/master'
jswhit2 Nov 30, 2021
e3aad64
Merge remote-tracking branch 'upstream/master'
jswhit2 Dec 16, 2021
344e1b1
Merge remote-tracking branch 'upstream/master'
jswhit2 Jan 6, 2022
b81a0a5
Merge remote-tracking branch 'upstream/master'
jswhit2 Jan 19, 2022
5f5a859
Merge remote-tracking branch 'upstream/master'
jswhit2 Mar 2, 2022
d2931d5
Merge branch 'master' of https://github.com/jswhit/GSI
jswhit2 Mar 2, 2022
15459d8
Merge remote-tracking branch 'upstream/master'
jswhit2 Apr 13, 2022
0a264f6
Merge remote-tracking branch 'upstream/develop'
jswhit2 Jul 14, 2022
dad7eed
Merge remote-tracking branch 'upstream/develop'
jswhit2 Sep 23, 2022
c2d7cbb
Merge remote-tracking branch 'upstream/develop'
jswhit2 Nov 14, 2022
0fa9c97
Merge remote-tracking branch 'upstream/develop'
jswhit2 Nov 22, 2022
fd4f5a1
Merge remote-tracking branch 'upstream/develop'
jswhit2 Nov 22, 2022
b22d832
Merge remote-tracking branch 'upstream/develop'
jswhit2 Jan 18, 2023
ad00538
Merge remote-tracking branch 'upstream/develop'
jswhit2 Jan 26, 2023
7d2ad1a
Merge remote-tracking branch 'upstream/develop'
jswhit2 Mar 5, 2023
179e808
Merge remote-tracking branch 'upstream/develop'
jswhit2 Jun 20, 2023
cbc0e67
Merge branch 'NOAA-EMC:develop' into master
jswhit Sep 20, 2023
ca24cef
fix for zero reference pressure for total ozone (causes Inf in log(p))
Sep 20, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/enkf/enkf_obsmod.f90
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,6 @@ subroutine readobs()
allocate(corrlengthsq(nobstot),lnsigl(nobstot),obtimel(nobstot))
lnsigl=1.e10
do nob=1,nobstot
oblnp(nob) = -log(obpress(nob)) ! distance measured in log(p) units
if (obloclon(nob) < zero) obloclon(nob) = obloclon(nob) + 360._r_single
radlon=deg2rad*obloclon(nob)
radlat=deg2rad*obloclat(nob)
Expand All @@ -283,6 +282,13 @@ subroutine readobs()
lnsigl(nob)=latval(deglat,lnsigcutoffnh,lnsigcutofftr,lnsigcutoffsh)
end if
endif
! total column ozone has pressure set to zero, set to 0.001Pa
! and turn vertical localization off (no effect if modelspace_vloc=T)
if (obpress(nob) < 0.001 .and. obtype(nob)(1:3) .eq. ' oz') then
lnsigl(nob) = 1.e30 ! turn ob-space vert localization off
obpress(nob) = 0.001 ! set to a non-zero value
endif
oblnp(nob) = -log(obpress(nob)) ! distance measured in log(p) units
corrlengthsq(nob)=latval(deglat,corrlengthnh,corrlengthtr,corrlengthsh)**2
if ( (obtype(nob)(1:3) == 'dbz' .or. obtype(nob)(1:3) == ' rw') .and. l_use_enkf_directZDA ) then
corrlengthsq(nob)=latval(deglat,corrlengthrdrnh,corrlengthrdrtr,corrlengthrdrsh)**2
Expand Down