Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update orion modulefile for rocky8 upgrade #140

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

aerorahul
Copy link
Contributor

As the title suggests.

Tested the build on Orion.

@DavidHuber-NOAA
Copy link
Collaborator

Same suggestion as for gfs-utils. Change

if [[ -d /apps/other ]]; then
# We are on Hercules
MACHINE_ID=hercules
else
MACHINE_ID=orion
fi

to

 elif [[ -d /work ]]; then 
  mount=$(findmnt -n -o SOURCE /home)
  if [[ ${mount} =~ "hercules" ]]; then
    MACHINE_ID=hercules
  else
    MACHINE_ID=orion
  fi

Copy link
Collaborator

@EdwardSafford-NOAA EdwardSafford-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@DavidHuber-NOAA
Copy link
Collaborator

GitHub PR and action are running in a degraded mode according to https://www.githubstatus.com/.

@DavidHuber-NOAA DavidHuber-NOAA merged commit e1f9f21 into develop Jun 28, 2024
4 checks passed
@DavidHuber-NOAA DavidHuber-NOAA deleted the feature/orion-rocky8 branch June 28, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants