Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yamls for JPSSRR sea-ice obs in cycling test #1300

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Yamls for JPSSRR sea-ice obs in cycling test #1300

merged 3 commits into from
Oct 1, 2024

Conversation

apchoiCMD
Copy link
Collaborator

@apchoiCMD apchoiCMD commented Sep 26, 2024 •
edited
Loading

This PR is to add the yaml keys

  • Yaml keys for JPSSRR sea-ice for the cycling
  • The file names of JPSSRR type sea-ice are the same in NH and SH, please see in yamls and obsprep_config.yaml
  • The preliminary results here/below
    GFSv17-3DVAR-C384mx025_gdasprepoceanobs_202106300600_NH
  • Obs for the SH is not ready yet

Related to #1259

@apchoiCMD apchoiCMD marked this pull request as ready for review September 26, 2024 18:47
@guillaumevernieres
Copy link
Contributor

Does the figure above has all the obs for the cycle? If so, there's probably a bug somewhere @apchoiCMD .

AndrewEichmann-NOAA
AndrewEichmann-NOAA reviewed Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add

@guillaumevernieres guillaumevernieres mentioned this pull request Oct 1, 2024
Closed
guillaumevernieres
guillaumevernieres approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@apchoiCMD
Copy link
Collaborator Author

Does the figure above has all the obs for the cycle? If so, there's probably a bug somewhere @apchoiCMD .

GFSv17-3DVAR-C384mx025_gdasprepoceanobs_20240618 00Z_SH

From the original files, zero values appears-

@guillaumevernieres guillaumevernieres merged commit af67dc0 into develop Oct 1, 2024
5 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/icec_jpssrr_yaml branch October 1, 2024 18:59
jiaruidong2017 pushed a commit that referenced this pull request Oct 3, 2024
@apchoiCMD @guillaumevernieres @jiaruidong2017
Yamls for JPSSRR sea-ice obs in cycling test (#1300)
37331a2 
#### This PR is to add the yaml keys
- Yaml keys for JPSSRR sea-ice for the cycling
- The file names of JPSSRR type sea-ice are the same in `NH` and `SH`,
please see in `yamls` and `obsprep_config.yaml`
- The preliminary results here/below

![GFSv17-3DVAR-C384mx025_gdasprepoceanobs_202106300600_NH](https://github.com/user-attachments/assets/d8276e1d-5fcb-4c04-92d7-67e902523035)
- Obs for the SH is not ready yet



Related to #1259

---------

Co-authored-by: Guillaume Vernieres <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@givelberg givelberg Awaiting requested review from givelberg

@JohnSteffen-NOAA JohnSteffen-NOAA Awaiting requested review from JohnSteffen-NOAA

@KatherineLukens-NOAA KatherineLukens-NOAA Awaiting requested review from KatherineLukens-NOAA

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apchoiCMD @guillaumevernieres @AndrewEichmann-NOAA @KatherineLukens-NOAA @JohnSteffen-NOAA