Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ABI sea-ice product to ioda converter #1280

Merged
merged 18 commits into from
Oct 18, 2024
Merged

Add ABI sea-ice product to ioda converter #1280

merged 18 commits into from
Oct 18, 2024

Conversation

apchoiCMD
Copy link
Collaborator

@apchoiCMD apchoiCMD commented Sep 12, 2024 •
edited
Loading

Description

  • Task for adding a new ioda converter for new ABI type sea-ice concentration
  • For sea-ice obs, AMSR2, MIRS, JPSSRR and ABI products will be used
  • For the part of conversion of metadata, the reference is here

Close #1182

@apchoiCMD apchoiCMD marked this pull request as ready for review September 19, 2024 13:36
AndrewEichmann-NOAA
AndrewEichmann-NOAA previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GLTM

JohnSteffen-NOAA
JohnSteffen-NOAA previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@JohnSteffen-NOAA JohnSteffen-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the walk through. Also, you may need to merge the latest develop branch first.

@apchoiCMD
Copy link
Collaborator Author

Updated results with original file;

combiled_crop

@apchoiCMD
Copy link
Collaborator Author

Tested ABI ioda converter within cycling test:

ABI_cycling_plot

guillaumevernieres
guillaumevernieres reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apchoiCMD , see comments.

utils/obsproc/IcecAbi2Ioda.h Outdated Show resolved Hide resolved
utils/obsproc/util.h Outdated Show resolved Hide resolved
utils/obsproc/util.h Outdated Show resolved Hide resolved
utils/obsproc/util.h Outdated Show resolved Hide resolved
utils/obsproc/util.h Outdated Show resolved Hide resolved
utils/obsproc/IcecAbi2Ioda.h Outdated Show resolved Hide resolved
utils/obsproc/IcecAbi2Ioda.h Outdated Show resolved Hide resolved
@guillaumevernieres
Copy link
Contributor

tested by @JohnSteffen-NOAA , does what it's supposed to.

@guillaumevernieres guillaumevernieres merged commit 352b372 into develop Oct 18, 2024
5 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/abi_sea_ice branch October 18, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnSteffen-NOAA JohnSteffen-NOAA JohnSteffen-NOAA approved these changes

@givelberg givelberg Awaiting requested review from givelberg

@KatherineLukens-NOAA KatherineLukens-NOAA Awaiting requested review from KatherineLukens-NOAA

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA

@guillaumevernieres guillaumevernieres Awaiting requested review from guillaumevernieres

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More converters for sea-ice obs
4 participants
@apchoiCMD @guillaumevernieres @AndrewEichmann-NOAA @JohnSteffen-NOAA