Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/b2i #1275

Merged
merged 58 commits into from
Sep 27, 2024
Merged

Feature/b2i #1275

merged 58 commits into from
Sep 27, 2024

Conversation

givelberg
Copy link
Collaborator

6 bufr to ioda converters
this is second refactoring of the code.
the variables are grouped into metadata, obs and additional ioda vars
metadata is read from a yaml file (could also be a json file)
additional variables now include ocean basin
converters generate log files and have a command line option to test
the log against a reference file
Log files contain some human readable data, as well as cryptographic
hash strings computed from the variables.
Simple utilities to plot data are included.

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Passed Automated testing with global-workflow successful on Hera hera-GW-RT Queue for automated testing with global-workflow on Hera labels Sep 13, 2024
@guillaumevernieres
Copy link
Contributor

@givelberg , your branch is behind develop and the code norm is failing ...

@guillaumevernieres
Copy link
Contributor

I'll run the test manually @givelberg , since I broke everything earlier today ...

@guillaumevernieres
Copy link
Contributor

I'll run the test manually @givelberg , since I broke everything earlier today ...

great, the build failed. Probably an issue on my side. I'll run the ci and cherry pick the ctests relevant to your changes @givelberg .

@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Sep 18, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Sep 18, 2024
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

test/soca/CMakeLists.txt Outdated Show resolved Hide resolved
test/soca/CMakeLists.txt Outdated Show resolved Hide resolved
test/soca/CMakeLists.txt Outdated Show resolved Hide resolved
@emcbot
Copy link

emcbot commented Sep 19, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Sep 18 20:21:03 UTC 2024 on hfe02
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Sep 18 21:05:53 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Sep 19 00:55:44 UTC 2024
Tests: 65% tests passed, 16 tests failed out of 46
	1892 - test_gdasapp_WCDA-3DVAR-C48mx500_gdasfcst_202103241200 (Failed)
	1893 - test_gdasapp_WCDA-3DVAR-C48mx500_gdasprepoceanobs_202103241800 (Failed)
	1902 - test_gdasapp_atm_jjob_var_init (Failed)
	1903 - test_gdasapp_atm_jjob_var_run (Failed)
	1904 - test_gdasapp_atm_jjob_var_inc (Failed)
	1905 - test_gdasapp_atm_jjob_var_final (Failed)
	1906 - test_gdasapp_atm_jjob_ens_init (Failed)
	1912 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1275/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Sep 19, 2024
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera labels Sep 26, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Sep 26, 2024
@emcbot
Copy link

emcbot commented Sep 26, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Sep 26 22:27:42 UTC 2024 on hfe02
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Sep 26 23:16:18 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Sep 26 23:56:04 UTC 2024
Tests: 87% tests passed, 6 tests failed out of 46
	1903 - test_gdasapp_atm_jjob_var_init (Failed)
	1904 - test_gdasapp_atm_jjob_var_run (Failed)
	1905 - test_gdasapp_atm_jjob_var_inc (Failed)
	1906 - test_gdasapp_atm_jjob_var_final (Failed)
	1907 - test_gdasapp_atm_jjob_ens_init (Failed)
	1908 - test_gdasapp_atm_jjob_ens_letkf (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1275/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Sep 26, 2024
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this @givelberg , but your tests were not triggered in the hera ci.

@guillaumevernieres guillaumevernieres merged commit 2be1fcd into develop Sep 27, 2024
11 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/b2i branch September 27, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants