Use standard config files for jjob test and give output files better names #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidNew-NOAA
requested review from
RussTreadon-NOAA,
CoryMartin-NOAA and
danholdaway
CoryMartin-NOAA
previously approved these changes
Jun 7, 2024
There was a problem hiding this comment.
If you like, @DavidNew-NOAA , I can clean up the if-elif blocks in the jjob*sh. Just let me know.
danholdaway
previously approved these changes
Jun 7, 2024
DavidNew-NOAA
dismissed stale reviews from danholdaway and CoryMartin-NOAA
via
34c80c0
RussTreadon-NOAA
approved these changes
Jun 7, 2024
danholdaway
added a commit
that referenced
this pull request
Jun 13, 2024
into feature/rename_atm * 'feature/rename_atm' of https://github.com/NOAA-EMC/GDASApp: Feature/rtofs in situ (#1138) Updates to aerosol yaml templates (#1158) Use standard config files for jjob test and give output files better names (#1156) Temporary removal of soca_vrfy task (#1157) Fix keyword for float tolerances in jjob tests (#1154) Create template YAML for n21 aerosol obs and update obs QC in YAMLs (#1152) Changes name of rossrad file for letkf (#1151) Adds staging jinja/yaml file for letkf task (#1137)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that G-W #2661 is merged, the custom config.atmanl and config.atmensanl used by the jjob tests can be deleted. This way, the custom files don't have to be updated everytime the standard ones are.
I also changed the sbatch submission, so the log files for each jjob test includes the name of the associated G-W job. This makes it a little easier to browse the logs, without having to guess which one is which.