forked from CICE-Consortium/CICE
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to UWM hash #88
Merged
NickSzapiro-NOAA
merged 6 commits into
NOAA-EMC:temporary
from
NickSzapiro-NOAA:develop
Sep 25, 2024
Merged
Update to UWM hash #88
NickSzapiro-NOAA
merged 6 commits into
NOAA-EMC:temporary
from
NickSzapiro-NOAA:develop
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CE-Consortium#958) Update CICE plotting tools. Add ciceplots.csh and ciceplots2d.py. Update timeseries.py. Remove timeseries.csh. Have the plotting tools copied into case directories. Update documentation. ciceplots2d.py generates global and polar plots for fields on CICE history files. ciceplots.csh is a general script that calls timeseries.py and ciceplots2d.py to generate plots for a user defined case. Add basemap to the cice conda environment.yml file to support the plotting packages. Add output to JRA55_files in ice_forcing.F90 to make it easier to understand when/why JRA55 files are missing. Add NO_CDF5 CPP to izumi_nag Macros file. Change 10 year production test case to 8 year test. This will serve as basis for release results. Update Icepack to #083d6e3cf42198 from May 28, 2024. Includes updates to Icepack plotting tools.
* replace shr_file with shr_log * Change names for stub routines --------- Co-authored-by: Jim Edwards <[email protected]>
…rtium#965) Add support for 'one-step' congelation ice formation in addition to current default 'two-step' option. Added a new namelist, congel_freeze to control the congelation option. This CICE update requires an update to Icepack to support the new congel_freeze option. The default setting for congel_freeze is set to 'two-step' for backwards compatibility. The new 'one-step' option will be evaluated and may become the default option in the future. Testing indicates the default setting is bit-for-bit identical with the current main.
…ICE-Consortium#966) Add ability for netcdf file reading to fall back to regular netcdf if a file is initially opened (for instance with hdf5 reading) and fails to open properly. For some versions of the PIO library (<2.5.10), attempting a parallel read with filetype netcdf4 (hdf5) of a file which does not support parallel reads fails. The expected behaviour (which is fixed in latest PIO versions) is to fall back to a serial read. The change ensures support for older PIO versions.
…e cpl_scalar field when created for UFS (CICE-Consortium#969) These are two commits cherry-picked from as in UFS and needed to close NOAA-EMC#84. This PR adds the ability for CICE to write restart files at the end of the run (independent of other settings) and controlled via the CMEPS configuration option write_restart_at_endofrun. Setting this configuration option to True creates a restart file in the same way for CMEPS, MOM6, and CICE. This PR also initializes the scalar field value for the index for NTile (implemented for FV3) not used or set in CICE. In certain cases, the scalar field value for this index has been found to be non-zero (NaN in debug compiles). This is the cause of the failure reported in ufs-community/ufs-weather-model#2338. * Add end of run functionality to CICE (NOAA-EMC#77) * initialize cpl_scalar field when created (NOAA-EMC#83) --------- Co-authored-by: Daniel Sarmiento <[email protected]> Co-authored-by: Denise Worthen <[email protected]>
Prescribed ice CICE was enclosed by #ifdef CESMCOUPLED in CMEPS driver. This allows use of prescribed ice CICE in ufs-weather-model with CDEPS calls to input (sea ice concentration) from file. Starting as cherry-picked as in UFS but dependency on CDEPS likely needs to be optional at compile time. This is needed for History conflicts between CICE-Consortium and emc/develop NOAA-EMC#84 * Enable prescribed ice for UFS (NOAA-EMC#80) * Remove #ifdef CESMCOUPLED from cicecore/drivers/nuopc/cmeps/CICE_RunMod.F90 * Remove #ifdef CESMCOUPLED from cicecore/drivers/nuopc/cmeps/ice_prescribed_mod.F90 * Testing changing stream_taxmode from cycle to extend * Change include mpif.h to use mpi in ice_prescribed_mod.F90 * Call dshr_pio_init from ice_prescribed_init * Call ice_prescribed_run after ice_prescribed_init * Incorporate ice_prescribed_nml in ice_prescribed_mod.F90 * write stream_taxmode to log. typo in ice_prescribed_mod.F90. * Remove CESMCOUPLED so models initialize ice_prescribed at end of ice_prescribed_init * Change indent for #ifndef for gnu debug * Only call ice_prescribed_run in ice_prescribed_init #ifndef CESMCOUPLED * Note CDEPS dependency in cicecore/drivers/nuopc/cmeps/ice_prescribed_mod.F90 * Remove stub prescribed ice code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
ENTER INFORMATION HERE
ENTER INFORMATION HERE
ENTER INFORMATION HERE