Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CICE from Consortium/main #59

Merged
merged 70 commits into from
Mar 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
d088bfb
Update some CICE variable names to clarify grid (#729)
apcraig Jul 15, 2022
1585c31
Add unit test for optional arguments, "optargs" (#730)
apcraig Jul 15, 2022
21bd95b
cice.setup: remove 'suite.jobs' at start of 'suite.submit' (#731)
phil-blain Jul 15, 2022
9be1c35
Deprecate CESM ponds (tr_pond_cesm) (#733)
dabail10 Jul 31, 2022
3af3d1b
Deprecate 0-layer thermodynamics in the CICE driver (#732)
eclare108213 Jul 31, 2022
c6470cf
Update icepack to 3cb1746a202615044e (#743)
apcraig Jul 31, 2022
063a7f2
Update cice.t-test.py to use cartopy instead of basemap. (#742)
apcraig Jul 31, 2022
731c61d
change visc_method default to avg_zeta, change alt07 to test avg_stre…
apcraig Aug 2, 2022
26db2c3
cice.setup: allow command line to override suite options (#745)
phil-blain Aug 2, 2022
5a1701c
Update Icepack and version number (#748)
apcraig Aug 4, 2022
08c6b33
ice_grid: do call 'gridbox_verts' for rectangular grids (#749)
phil-blain Aug 12, 2022
d673e44
Clean up code and add several minor features (#750)
apcraig Aug 15, 2022
75ef5d2
Update ECCC machine files (#751)
phil-blain Aug 17, 2022
fea412a
ice_calendar: zero-initialize 'nstreams' (#752)
phil-blain Aug 17, 2022
1f70caf
Merge remote-tracking branch 'Consortium/main' into feature/updcice
DeniseWorthen Aug 20, 2022
c87dcd3
Added dxgrow, dygrow to facilitate variable spaced grid. Modified rec…
daveh150 Aug 22, 2022
2d0b213
Update Pull Request Template, add question about updating Icepack (#754)
apcraig Aug 23, 2022
588a86f
Refactored evp sub cycling loop (#756)
TillRasmussen Aug 24, 2022
007fbff
ice_grid: initialize 'l_readCenter' for all grid types (#758)
phil-blain Aug 24, 2022
6587995
move deformation out of loop for B grid only (#755)
TillRasmussen Sep 22, 2022
6399af7
Update dEdd implementation (#760)
apcraig Sep 29, 2022
036f1f7
Update grid averaging for tmass, aice, uvelT, vvelT (#762)
apcraig Sep 29, 2022
422117f
doc: improve "Quick Start" section (#765)
phil-blain Oct 6, 2022
8c6ba04
Refactor strocnxT, strocnyT implementation (#764)
apcraig Oct 10, 2022
578c111
ice_init: do broadcast 'default_season' (#766)
phil-blain Oct 11, 2022
af8cc84
Correct units in FSD history output (#769)
lettie-roach Oct 11, 2022
6a62a11
Update box test options (#772)
apcraig Oct 14, 2022
0447b9e
Update computation of cdn_ocn for use in dynamics (#771)
apcraig Oct 14, 2022
2435fa7
Change icetmask to logical consistent with iceumask, icenmask, iceema…
apcraig Oct 17, 2022
16b78da
ice_dyn_vp: allow for bit-for-bit reproducibility under `bfbflag` (#774)
phil-blain Oct 20, 2022
db2d7a9
Update Narwhal Port (#776)
apcraig Oct 20, 2022
670d2f2
Add time-varying wave forcing, add warning for FSD without waves, mak…
lettie-roach Nov 1, 2022
3820cde
Port to gust intel and cray (#781)
apcraig Nov 1, 2022
d6d081a
Merge branch 'emc/develop' into feature/updcice
DeniseWorthen Nov 2, 2022
2e68b9e
Merge remote-tracking branch 'Consortium/main' into feature/updcice
DeniseWorthen Nov 2, 2022
b893ee9
add initializationsin ice_state
DeniseWorthen Nov 2, 2022
aa1e066
Update KE diagnostic (#784)
apcraig Nov 7, 2022
251ca48
Add wave-ice coupling to nuopc/cmeps driver (#782)
DeniseWorthen Nov 8, 2022
b11bfb4
Merge remote-tracking branch 'Consortium/main' into feature/updcice
DeniseWorthen Nov 8, 2022
5a32f12
finalize 0-layer thermo and cesm ponds deprecation in CICE (#787)
eclare108213 Nov 16, 2022
9808b51
CESM Updates (#785)
dabail10 Nov 16, 2022
fe16051
Merge remote-tracking branch 'Consortium/main' into feature/updcice
DeniseWorthen Nov 16, 2022
99daf69
allocate c and cd var in evp, reduce number of "if grid_ice". (#778)
TillRasmussen Nov 17, 2022
9104a8c
Rename cicedynB to cicedyn, update test suites (#790)
apcraig Nov 18, 2022
ed4855e
Update Icepack (#794)
apcraig Nov 19, 2022
cb58257
Trap solve_zsal = true at initialization (#795)
apcraig Nov 20, 2022
b16d7fd
Update Icepack to #5999551 including snowbrinebugs (#797)
apcraig Dec 2, 2022
90a8b62
Merge branch 'NOAA-EMC:emc/develop' into feature/updcice
DeniseWorthen Dec 6, 2022
ad8d577
Merge remote-tracking branch 'Consortium/main' into feature/updcice
DeniseWorthen Dec 6, 2022
4befa1e
Saltflux option for CICE (#799)
dabail10 Dec 7, 2022
48cf07a
Update stress12T calculation for C-grid (#802)
apcraig Dec 7, 2022
f813294
Update version to CICE 6.4.1 (#803)
apcraig Dec 7, 2022
eebb350
Adding method to check namelist in any order, tested with NAG Fortran…
daveh150 Dec 16, 2022
0bf0fdc
Fix OMP setup and 'setmask' (#806)
dabail10 Dec 17, 2022
ce2298e
Merge remote-tracking branch 'Consortium/main' into feature/updcice
DeniseWorthen Jan 4, 2023
ed472ab
fix for nudiag_set
DeniseWorthen Jan 9, 2023
506614d
Merge remote-tracking branch 'CICE-Consortium/main' into test
DeniseWorthen Jan 14, 2023
dd25b0f
Merge branch 'test' into feature/updcice
DeniseWorthen Jan 14, 2023
28fdbeb
Fix for rare instability in (probabilistic) seabed stress (#810)
JFLemieux73 Jan 19, 2023
b946a95
Some small CESM updates. (#812)
dabail10 Feb 1, 2023
d73bb8b
Add time_period_freq (#816)
dabail10 Mar 2, 2023
ee68d3f
Merge branch 'emc/develop' into feature/updcice
DeniseWorthen Mar 7, 2023
6671e32
Merge remote-tracking branch 'Consortium/main' into feature/updcice
DeniseWorthen Mar 7, 2023
0fcc140
doc, ice_history: correct units for 'sigP' and improve doc for stress…
phil-blain Mar 8, 2023
9a55ad9
cicecore: correct initial condition metadata (#818)
phil-blain Mar 13, 2023
75b792c
Add haloupdate unit test (#820)
apcraig Mar 13, 2023
03615e8
Update Icepack to #37e215b532 March 3, 2023 (#821)
apcraig Mar 14, 2023
adce222
update documentation (#822)
apcraig Mar 15, 2023
7df80ba
FSD updates for icepack. (#813)
dabail10 Mar 15, 2023
5840cd1
Merge remote-tracking branch 'Consortium/main' into feature/updcice
DeniseWorthen Mar 22, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cicecore/cicedyn/analysis/ice_history.F90
Original file line number Diff line number Diff line change
Expand Up @@ -1341,7 +1341,7 @@ subroutine init_hist (dt)
"sig2 is instantaneous" // trim(description), c1, c0, &
ns1, f_sig2)

call define_hist_field(n_sigP,"sigP","1",gridstr2d, gridstr, &
call define_hist_field(n_sigP,"sigP","N/m",gridstr2d, gridstr, &
"ice pressure", &
"sigP is instantaneous" // trim(description), c1, c0, &
ns1, f_sigP)
Expand Down
11 changes: 6 additions & 5 deletions cicecore/cicedyn/dynamics/ice_dyn_shared.F90
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ module ice_dyn_shared
yield_curve , & ! 'ellipse' ('teardrop' needs further testing)
visc_method , & ! method for viscosity calc at U points (C, CD grids)
seabed_stress_method ! method for seabed stress calculation
! LKD: Lemieux et al. 2015, probabilistic: Dupont et al. in prep.
! LKD: Lemieux et al. 2015, probabilistic: Dupont et al. 2022

real (kind=dbl_kind), parameter, public :: &
u0 = 5e-5_dbl_kind, & ! residual velocity for seabed stress (m/s)
Expand Down Expand Up @@ -1347,8 +1347,9 @@ end subroutine seabed_stress_factor_LKD
! a normal distribution with sigma_b = 2.5d0. An improvement would
! be to provide the distribution based on high resolution data.
!
! Dupont, F. Dumont, D., Lemieux, J.F., Dumas-Lefebvre, E., Caya, A.
! in prep.
! Dupont, F., D. Dumont, J.F. Lemieux, E. Dumas-Lefebvre, A. Caya (2022).
! A probabilistic seabed-ice keel interaction model, The Cryosphere, 16,
! 1963-1977.
!
! authors: D. Dumont, J.F. Lemieux, E. Dumas-Lefebvre, F. Dupont
!
Expand Down Expand Up @@ -1481,13 +1482,13 @@ subroutine seabed_stress_factor_prob (nx_block, ny_block, &
do n =1, ncat
v_i = v_i + vcat(n)**2 / (max(acat(n), puny))
enddo
v_i = v_i - m_i**2
v_i = max((v_i - m_i**2), puny)

mu_i = log(m_i/sqrt(c1 + v_i/m_i**2)) ! parameters for the log-normal
sigma_i = sqrt(log(c1 + v_i/m_i**2))

! max thickness associated with percentile of log-normal PDF
! x_kmax=x997 was obtained from an optimization procedure (Dupont et al.)
! x_kmax=x997 was obtained from an optimization procedure (Dupont et al. 2022)

x_kmax = exp(mu_i + sqrt(c2*sigma_i)*1.9430d0)

Expand Down
4 changes: 3 additions & 1 deletion cicecore/cicedyn/general/ice_flux.F90
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,7 @@ module ice_flux
vatmT , & ! vatm on T grid (m/s)
rside , & ! fraction of ice that melts laterally
fside , & ! lateral heat flux (W/m^2)
wlat , & ! lateral heat rate (m/s)
fsw , & ! incoming shortwave radiation (W/m^2)
coszen , & ! cosine solar zenith angle, < 0 for sun below horizon
rdg_conv, & ! convergence term for ridging (1/s)
Expand Down Expand Up @@ -540,7 +541,8 @@ subroutine alloc_flux
uatmT (nx_block,ny_block,max_blocks), & ! uatm on T grid
vatmT (nx_block,ny_block,max_blocks), & ! vatm on T grid
rside (nx_block,ny_block,max_blocks), & ! fraction of ice that melts laterally
fside (nx_block,ny_block,max_blocks), & ! lateral melt rate (W/m^2)
fside (nx_block,ny_block,max_blocks), & ! lateral melt flux (W/m^2)
wlat (nx_block,ny_block,max_blocks), & ! lateral melt rate (m/s)
fsw (nx_block,ny_block,max_blocks), & ! incoming shortwave radiation (W/m^2)
coszen (nx_block,ny_block,max_blocks), & ! cosine solar zenith angle, < 0 for sun below horizon
rdg_conv (nx_block,ny_block,max_blocks), & ! convergence term for ridging (1/s)
Expand Down
2 changes: 1 addition & 1 deletion cicecore/cicedyn/general/ice_init.F90
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ subroutine input_data
dyscale = 1.0_dbl_kind ! user defined rectgrid y-grid scale factor (e.g., 1.02)
close_boundaries = .false. ! true = set land on edges of grid
seabed_stress= .false. ! if true, seabed stress for landfast is on
seabed_stress_method = 'LKD'! LKD = Lemieux et al 2015, probabilistic = Dupont et al. in prep
seabed_stress_method = 'LKD'! LKD = Lemieux et al 2015, probabilistic = Dupont et al. 2022
k1 = 7.5_dbl_kind ! 1st free parameter for landfast parameterization
k2 = 15.0_dbl_kind ! 2nd free parameter (N/m^3) for landfast parametrization
alphab = 20.0_dbl_kind ! alphab=Cb factor in Lemieux et al 2015
Expand Down
6 changes: 4 additions & 2 deletions cicecore/cicedyn/general/ice_step_mod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ subroutine step_therm1 (dt, iblk)
use ice_calendar, only: yday
use ice_domain_size, only: ncat, nilyr, nslyr, n_iso, n_aero
use ice_flux, only: frzmlt, sst, Tf, strocnxT_iavg, strocnyT_iavg, rside, fbot, Tbot, Tsnice, &
meltsn, melttn, meltbn, congeln, snoicen, uatmT, vatmT, fside, &
meltsn, melttn, meltbn, congeln, snoicen, uatmT, vatmT, fside, wlat, &
wind, rhoa, potT, Qa, zlvl, zlvs, strax, stray, flatn, fsensn, fsurfn, fcondtopn, &
flw, fsnow, fpond, sss, mlt_onset, frz_onset, fcondbotn, fcondbot, fsloss, &
frain, Tair, strairxT, strairyT, fsurf, fcondtop, fsens, &
Expand Down Expand Up @@ -469,6 +469,7 @@ subroutine step_therm1 (dt, iblk)
frzmlt = frzmlt (i,j, iblk), &
rside = rside (i,j, iblk), &
fside = fside (i,j, iblk), &
wlat = wlat (i,j, iblk), &
fsnow = fsnow (i,j, iblk), &
frain = frain (i,j, iblk), &
fpond = fpond (i,j, iblk), &
Expand Down Expand Up @@ -618,7 +619,7 @@ subroutine step_therm2 (dt, iblk)
use ice_calendar, only: yday
use ice_domain_size, only: ncat, nilyr, nslyr, nblyr, nfsd
use ice_flux, only: fresh, frain, fpond, frzmlt, frazil, frz_onset, &
update_ocn_f, fsalt, Tf, sss, salinz, fhocn, rside, fside, &
update_ocn_f, fsalt, Tf, sss, salinz, fhocn, rside, fside, wlat, &
meltl, frazil_diag
use ice_flux_bgc, only: flux_bio, faero_ocn, &
fiso_ocn, HDO_ocn, H2_16O_ocn, H2_18O_ocn
Expand Down Expand Up @@ -702,6 +703,7 @@ subroutine step_therm2 (dt, iblk)
rside = rside (i,j, iblk), &
meltl = meltl (i,j, iblk), &
fside = fside (i,j, iblk), &
wlat = wlat (i,j, iblk), &
frzmlt = frzmlt (i,j, iblk), &
frazil = frazil (i,j, iblk), &
frain = frain (i,j, iblk), &
Expand Down
Loading