-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend n3fit and vp to deal with two different initial state distributions #2110
Conversation
init work on theory covmat some other work on pineparser, not working yet lumi to channels remove is_polarized and make it working
c879ba8
to
2b86ae3
Compare
Refactor boundary condition as part of the PDF object
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for the reports / fits to be ready to make sure, but lgtm
Everything now works as expected here (and consistent with previous results). For the record, here are some extensive fit comparisons: https://vp.nnpdf.science/tEj54eRbTkeWaSXqA3MQWQ==/ |
Co-authored-by: Juan M. Cruz-Martinez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For completeness, I'm going to try and run a parallel fit with this branch.
Looking through the changes in n3fit I noticed a potential bug running polarized fits in parallel. I'll report back once the fits are finished.
For the rest (docs, -sequential- fits, reports) everything looks ok.
Co-authored-by: Juan M. Cruz-Martinez <[email protected]>
Here's a report comparing one of the fits in @Radonirinaunimi's report, with the fit run in a GPU. https://vp.nnpdf.science/KV97c7yfTRCt5PEOZ6Dh1g== Everything seems to work well :) (given past experiences I want to make sure we have a lot of granularity around these commits that can potentially change things in the fit behavior!) |
Perfect! Thanks a lot for this check @scarlehoff! |
The following PR modifies both n3fit and vp to deal with the case in which (SI)DIS/DY processes involve convolutions between two different distributions (PDF, pPDF, FF, etc.). A simple example of such a scenario is the case in which one of the protons is polarized and the other not:
This PR introduces a feature available since pineappl
<v0.8.0
that specifies the type of convolution required by an initial state with theconvolution_type_
key (whose value can beUnpolPDF
,PolPDF
,FF
).The main modifications affect:
Minimal non-congruent modifications:
is_polarized
logicalTo do at the very last stage:
Rely on NNPDF/pineappl#289, NNPDF/pineko#181.