Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kinematic coverage for polarized DIS processes #2109

Merged
merged 41 commits into from
Aug 16, 2024
Merged

Fix kinematic coverage for polarized DIS processes #2109

merged 41 commits into from
Aug 16, 2024

Conversation

Radonirinaunimi
Copy link
Member

Addresses #2104.

@Radonirinaunimi Radonirinaunimi added the Polarised Polarised PDF fits label Jun 7, 2024
@Radonirinaunimi Radonirinaunimi mentioned this pull request Jun 7, 2024
Closed
Radonirinaunimi and others added 25 commits July 30, 2024 22:21
@Radonirinaunimi
merge changes from master
5c84266
@Radonirinaunimi
fix xq2 maps for DIS datasets given in Q2 from cd
296b23b
@RoyStegeman @Radonirinaunimi
start updating ds names in vp
0f2220b
@RoyStegeman @Radonirinaunimi
update dsnames test_print_systype_overlap
76fc11f
@enocera @Radonirinaunimi
Conversion of data set names in vp example runcards - firt attempt
9e6a7cc
@enocera @Radonirinaunimi
Changing names from old to new in vp tests - first attempt
8cb955d
@enocera @Radonirinaunimi
Changed old commondata names to new ones in vp example runcards - alm…
a44d8d7 
…ost done
@enocera @Radonirinaunimi
Updating names
d540987
@peterkrack @Radonirinaunimi
update docs and last vp-tests to new commondata.
88f1d4e
@peterkrack @Radonirinaunimi
update dataset names.
42875c6
@enocera @Radonirinaunimi
Updated dataspecs test figure
d5d17cb
@scarlehoff @Radonirinaunimi
update tests
4e5bd8d
@scarlehoff @Radonirinaunimi
run black
100e5dd
@scarlehoff @Radonirinaunimi
update xq2 plot with newer versions of software
6a09adc
@RoyStegeman @Radonirinaunimi
update author key in examples to Lazy Person
bb0c198
@RoyStegeman @Radonirinaunimi
allow for underscore in the name of the theory files
958127e
@RoyStegeman @Radonirinaunimi
quickfix
9b35561
@RoyStegeman @Radonirinaunimi
raise error if two different theoryfiles have the same ID
81095b6
@RoyStegeman @Radonirinaunimi
correclty read theoryfile
da26adb
@RoyStegeman @Radonirinaunimi
propagate that theoryid is now (correctly) stored as in instead of st…
ae7a644 
…ring
@RoyStegeman @Radonirinaunimi
raise TheoryNotFoundInDatabase error if theory not found
db36a25
@RoyStegeman @Radonirinaunimi
no longer the need to check if theorycard exists
9f84a80
@RoyStegeman @Radonirinaunimi
use get_available_theory_cards in fetch_all
cc9bae4
@RoyStegeman @scarlehoff @Radonirinaunimi
Update nnpdf_data/nnpdf_data/theorydbutils.py
b5641f9 
Co-authored-by: Juan M. Cruz-Martinez <[email protected]>
@Radonirinaunimi
Merge branch 'master' into polarized-kin-coverage
3d91017
@giacomomagni giacomomagni linked an issue Aug 12, 2024 that may be closed by this pull request
Kinematic coverage for polarized datasets #2104
Closed
scarlehoff
scarlehoff reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Did you already created by any chance kinematic coverage plots with the latest version of this branch?

@giacomomagni
Copy link
Contributor

Thanks. Did you already created by any chance kinematic coverage plots with the latest version of this branch?

Not yet, the current fits are still based on the old dataset names so I couldn't produce the full plot.
But a DIS+DY coverage should work.

@scarlehoff
Copy link
Member

Actually that's a good point... I've created the plot with one of @Radonirinaunimi fits, please check that it is (relatively) sensible. This way this is also testing that the translation in dataset_names.yaml is working as expected (I'm using the datasets directly from the fit).

https://vp.nnpdf.science/7F2RTYKkQZW5TUT4HqECWw==

@scarlehoff
Copy link
Member

scarlehoff commented Aug 16, 2024 •
edited
Loading

If the plot in the previous msg looks ok, I think this can be merged. Maybe merging first from master to make sure tests pass and whatsnot.

@Radonirinaunimi
Copy link
Member Author

Sorry for having forgotten about this. This is ok, and the kinematic plots are good.

We can merge this!

@scarlehoff scarlehoff merged commit 69738d3 into master Aug 16, 2024
6 checks passed
@scarlehoff scarlehoff deleted the polarized-kin-coverage branch August 16, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarlehoff scarlehoff scarlehoff left review comments

@giacomomagni giacomomagni giacomomagni approved these changes

Assignees
No one assigned
Labels
Polarised Polarised PDF fits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kinematic coverage for polarized datasets
6 participants
@Radonirinaunimi @giacomomagni @scarlehoff @RoyStegeman @enocera @peterkrack