-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of recommonmark
dependency
#2101
base: master
Are you sure you want to change the base?
Conversation
Thanks a lot for starting this! Don't forget to also delete the markdown file you're replacing. |
Yes, I was't sure whether I should've deleted them or not. I was waiting for your feedback, many thanks! |
6d41900
to
69433fd
Compare
6717d3a
to
059c603
Compare
I'm currently working on this PR. I just want to mention that nested inline markups are currently not possible in reStructuredText, as explained here. There are some workarounds, but they are really ugly and are not worth the effort. Also, the documentation discourages to adopt them. This just to say that, in converting md to rst, I'm not using nested inline markups when dealing with cross-references. |
thanks, it's a bit ugly anyway so that's fine. |
Just to make a note on the last commit (the one addressing the old |
Ok, I think I'm done. Please, @RoyStegeman and @scarlehoff could you please check that I didn't forget anything? |
ac28972
to
fa9c9ef
Compare
Thanks! I'll have a look next week. |
Could you also remove it from the dependencies? |
I only see dependencies on |
Yes exactly, I suspect you will also have to remove the recommonmark settings from some config file if you haven't already. |
Ok, the doc compiles even after that. Here you can find the log of the build (both stdout and stderr). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
At some point we should also take care of the (important) warning such as non-existent labels #1360
This PR addresses #1978.