Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use results to create th uncertainties with pdf errors. #2051

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

scarlehoff
Copy link
Member

This is necessary to allow for things like #2049 but in general it also cleans up the code as more things are concentrated under results.

@achiefa you will need to rebase on top of this branch if you want to add pdf errors but I think for the time being you don't need them so you can wait until it is in master.

@RoyStegeman
Copy link
Member

Could you be more explicit in your explanation? What is the example nb trying to do that needs this? It seems that all this does is replace the exp covmat with an identity matrix, but I don't believe it is ever read anyway. Is it to save the computational resources?

@scarlehoff
Copy link
Member Author

pdferr_plus_dataset_inputs_covmat needs to compute the predictions for a dataset in order to generate the covariance matrix with exp + pdf error.

Ideally we want to get everything in validphys through a result object* but this creates a chicken-and-egg problem because the results object includes the covmat, so this adds as well a result obect without a covmat.

*and the notebook is based on monkeypatching the results (and results_with_thcovmat) objects

@scarlehoff scarlehoff merged commit 3ff2773 into master Apr 16, 2024
6 checks passed
@scarlehoff scarlehoff deleted the use_results_for_pdferr branch April 16, 2024 08:21
@scarlehoff scarlehoff mentioned this pull request May 20, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants