Closure with same level1 #2007
Closure with same level1 #2007
Conversation
There was a problem hiding this comment.
Thanks, this seems correct to me. Along with the notebook. Perhaps you'll want to rebase though since switching between this branch master has some delay due to the massive amount of data files moved (and there have been some improvements in particular regarding python and tensorflow versions)
| "covariance matrix has not been implemented yet." | ||
| ) | ||
| return validphys.filters.filter_closure_data_by_experiment | ||
| if theorycovmatconfig is not None: |
There was a problem hiding this comment.
I guess the theorycovmatconfig.get("use_thcovmat_in_sampling") should still be checked.
…06-in-a-closure-test' into closure_with_same_level1
|
Maybe it's better to get the changed cut back into master ASAP, to limit the number of affected fits. Could you open a separate PR for it? |
Yes sorry, I did it here for the moment just to test |
This is just a draft in which I collected some hack I need to do for the alpha_s closure test study. @RoyStegeman