Implement LHCB_WENU_8TEV #1889
Open
Implement LHCB_WENU_8TEV #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks a lot @niclaurenti for this! I know that this is still in a draft mode but since we discussed this briefly I added some comments below.
Co-authored-by: Tanjona Rabemananjara <[email protected]>
Radonirinaunimi
requested changes
Dec 15, 2023
There was a problem hiding this comment.
Thanks again @niclaurenti for this! I've added a couple of corrections below.
I suggest to rename the dataset to be LHCB_WPWM_8TEV_DILEPTON in order to be confirm with the new naming conventions. Also, you should add the mapping from the old to the new name in dataset_names.yml:
LHCB_WENU_8TEV_R: LHCB_WPWM_8TEV_DILEPTON
|
Missing: producing the grids and the fktables for these datasets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.