update to CommonOPF v0.4.4, clean house

Project.toml

@@ -13,7 +13,7 @@ MetaGraphsNext = "fa8bd995-216d-47f1-8a91-f3b68fbeb377"
 SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 
 [compat]
-CommonOPF = "0.4.3"
+CommonOPF = "0.4.4"
 Graphs = "1.8"
 JSON = "0.21"
 JuMP = "1"

src/model_multi_phase.jl

@@ -48,6 +48,8 @@ Add variables and constraints to `m` using the values in `net`. Calls the follow
 function build_bfm!(m::JuMP.AbstractModel, net::Network{MultiPhase}, ::Val{Linear})
     add_linear_variables(m, net)
     constrain_linear_power_balance(m, net)
+    # TODO finish the Linear multiphase model
+    # constrain_KVL_linear(m, net)
 end
 
 

test/runtests.jl

@@ -24,26 +24,6 @@ CPF = BranchFlowModel.CommonOPF
 
 Random.seed!(42)
 
-# TODO alot of these methods should be in modules
-function dss_voltages_pu()
-    d = Dict()
-    for b in OpenDSS.Circuit.AllBusNames() 
-        OpenDSS.Circuit.SetActiveBus(b)
-        d[b] = OpenDSS.Bus.puVmagAngle()[1:2:end]
-    end
-    return d
-end
-
-
-function dss_voltages_mag_angle()
-    d = Dict()
-    for b in OpenDSS.Circuit.AllBusNames() 
-        OpenDSS.Circuit.SetActiveBus(b)
-        d[b] = OpenDSS.Bus.VMagAngle()#[1:2:end]
-    end
-    return d
-end
-
 
 function build_single_phase_min_loss_model(net::CPF.Network{CPF.SinglePhase})
     m = Model(Ipopt.Optimizer)
@@ -325,7 +305,7 @@ end
     cd(work_dir)
     @test(OpenDSS.Solution.Converged() == true)
 
-    dss_voltages = dss_voltages_pu()
+    dss_voltages = CPF.dss_voltages_pu()
 
     net = CPF.dss_to_Network(dssfilepath)
     @test net.substation_bus == "sourcebus"
@@ -492,7 +472,7 @@ end
 
     @test(check_opendss_powers() == true)
 
-    dss_voltages = dss_voltages_pu()
+    dss_voltages = CPF.dss_voltages_pu()
 
     net = CPF.dss_to_Network(dssfilepath)
 
@@ -596,7 +576,7 @@ end
     """)
     cd(work_dir)
     @test(OpenDSS.Solution.Converged() == true)
-    dss_voltages = dss_voltages_pu()
+    dss_voltages = CPF.dss_voltages_pu()
 
     for b in keys(vs)
         @test abs(vs[b][1] - dss_voltages[b][1]) < 0.001
@@ -761,7 +741,7 @@ end
     OpenDSS.dss("Solve")
     @test(OpenDSS.Solution.Converged() == true)
     @test(check_opendss_powers() == true)
-    dss_voltages = dss_voltages_pu()
+    dss_voltages = CPF.dss_voltages_pu()
 
 
     # make the regulator work like OpenDSS

test/test_linear.jl

@@ -31,6 +31,6 @@ end
     m = Model(HiGHS.Optimizer)
 
     build_bfm!(m, net, Linear)
-
+    # TODO finish the linear multiphase model
 
 end

test/test_nlp.jl

@@ -15,7 +15,7 @@
 
 
     m = Model(Ipopt.Optimizer)
-    # set_optimizer_attribute(m, "print_level", 0)
+    set_optimizer_attribute(m, "print_level", 0)
 
     build_bfm!(m, net, Unrelaxed)
 
@@ -73,7 +73,7 @@
     @test(OpenDSS.Solution.Converged() == true)
     @test(check_opendss_powers() == true)
 
-    dss_voltages = dss_voltages_pu()
+    dss_voltages = CPF.dss_voltages_pu()
 
     for b in keys(vs)
         for (i, phsv) in enumerate(filter(v -> v != 0, vs[b]))