Fix #281 - Render supernet table by smallest prefix first #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxsasha
force-pushed
the
supernets
branch
2 times, most recently
from
af56ab8
to
cbc9c14
Compare
|
@mxsasha most Akamai prefixes work fine, for example 2.16.27.0/24. |
There is definitely a lot of rows, but not sure if we're improving something with this change. I don't remember our discussion clearly enough on why we decided on this particular approach. current
modified sorting in this PR
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@teunvink do we have some sample prefixes where this problem was seen? I've implemented the change we decided on, sorting the supernet table by smallest prefix size first, IP second, by default. But I'm not sure it's helping.