Merge pull request #114 from NIFU-NO/dev

Dev
NIFU-NO · Aug 24, 2024 · dc38761 · dc38761
2 parents 8ca6aa0 + fdf6271
commit dc38761
Show file tree

Hide file tree

Showing 4 changed files with 214 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -60,7 +60,8 @@ Suggests:
 	  tibble,
     withr,
     quarto,
-    spelling
+    spelling,
+    vdiffr
 Config/testthat/edition: 3
 Encoding: UTF-8
 RoxygenNote: 7.3.2

diff --git a/R/summarize_cat_cat_data.R b/R/summarize_cat_cat_data.R
@@ -3,9 +3,11 @@
 # Helper function to create overarching factor variable for the response categories column
 category_var_as_fct <-
   function(data_summary, fct_unions) {
+
     data_summary$.category <- factor(x = data_summary$.category,
                                      levels = fct_unions,
-                                     labels = fct_unions)
+                                     labels = fct_unions,
+                                     exclude = NULL)
     data_summary
   }
 

diff --git a/tests/testthat/_snaps/make_content.cat_plot_html/unused-categories-in-legend.svg b/tests/testthat/_snaps/make_content.cat_plot_html/unused-categories-in-legend.svg
diff --git a/tests/testthat/test-make_content.cat_plot_html.R b/tests/testthat/test-make_content.cat_plot_html.R
@@ -0,0 +1,8 @@
+testthat::test_that("show.legend works with unused categories", {
+    vdiffr::expect_doppelganger(title = "Unused categories in legend",
+                                fig = {
+      saros.contents::ex_survey |>
+        dplyr::filter(dplyr::if_all(p_1:p_4, ~.x != "Strongly agree")) |>
+        saros.contents::makeme(dep=p_1:p_4, indep=x1_sex)
+    })
+})