Feature/allow var tmp #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…typically a writable space.
…just the tests to account for it
…low rpmbuild to set it
agaur-lbl
reviewed
Oct 10, 2019
src/VolumeMap.c
Outdated
| @@ -585,6 +589,7 @@ int _validateVolumeMap( | |||
| const char *from, | |||
| const char *to, | |||
| VolumeMapFlag *flags, | |||
| const char **toExactAllowed, | |||
There was a problem hiding this comment.
doh! i'll fix that
|
Overall looks good, i would like paths to be configurable. Special paths can be given special consideration. |
|
the spacing is corrected. It looks like travisci fell apart on the previous push owing to a transient failure at travis. hopefully this push will build. |
|
re: making paths configurable, i believe that is in-general possible. /var is a little touchy owing to its security issues. I don't think there is any harm in /var/tmp, but other paths within var could be more problematic. We can re-address the overall configurability in a branch focused on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for issue #262