Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve siteFs #173

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Improve siteFs #173

wants to merge 9 commits into from

Conversation

rukkal
Copy link
Contributor

@rukkal rukkal commented May 4, 2017

This PR adds two improvements:

  1. The function setupVolumeMapMounts now uses mkdir_p instead of the plain mkdir in order to create parent folders, if necessary. E.g. the following configuration in udiRoot.conf no longer requires the system administrator to use sitePreMountHook to create the parent folder:
siteFs=/var/opt/cray/alps:/var/opt/cray/alps:rec
  1. Shifter could drop/skip data of the image when the system administrator configures siteFs to mount folders that clash with the contents of the image. We modified Shifter to emit a warning when potentially important data is being skipped.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 67.863% when pulling 5671540 on rukkal:improve_sitefs into 4dc2134 on NERSC:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants