Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use numpy.prod instead on numpy.product #12

Merged
merged 4 commits into from
Jul 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ name: Python package

on:
push:
branches: [ master ]
branches: [ master, issue60 ]
pull_request:
branches: [ master ]

Expand All @@ -30,6 +30,7 @@ jobs:
python -m pip install flake8 pytest
python -m pip install -e .
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
python -m pip list
- name: Lint with flake8
run: |
# stop the build if there are Python syntax errors or undefined names
Expand Down
2 changes: 1 addition & 1 deletion pyfive/dataobjects.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def unpack_attribute(self, offset):

# read in the dataspace information
shape, maxshape = determine_data_shape(self.msg_data, offset)
items = int(np.product(shape))
items = int(np.prod(shape))
offset += _padded_size(attr_dict['dataspace_size'], padding_multiple)

# read in the value(s)
Expand Down