Fix bug that returned incorrect results when an invalid identifer is provided to cf.Field.cell_methods
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadielbartholomew
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
One typo in the changelog and formatting issue, but otherwise perfect with sufficient new testing. +1 for the new examples for the docs. Please merge once the minor comments are addressed.
(FYI as part of testing, in case of logic re-use and because bugs can, I did a quick check that other multiple construct getting methods don't display the same bug, e.g. f.coordinate_references and f.domain_axes('bad'), but all looks good.)
|
|
||
| * Fix bug that returned incorrect results when an invalid identifer is | ||
| provided to `cf.Field.cell_methods` | ||
| (https://github.com/NCAS-CMS/cfdm/issues/2699) |
There was a problem hiding this comment.
Suggested change
| (https://github.com/NCAS-CMS/cfdm/issues/2699) | |
| (https://github.com/NCAS-CMS/cfdm/issues/299) |
(That would be a worrying amount of issues to have registered!)
| >>> print(f.cell_methods()) | ||
| Constructs: | ||
| {'cellmethod0': <CellMethod: domainaxis1: domainaxis2: mean where land (interval: 0.1 degrees)>, | ||
| 'cellmethod1': <CellMethod: domainaxis3: maximum>} |
There was a problem hiding this comment.
Suggested change
| 'cellmethod1': <CellMethod: domainaxis3: maximum>} | |
| 'cellmethod1': <CellMethod: domainaxis3: maximum>} |
(for the accurate, and more readable, alignment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #299