-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links to point to new home of cf-plot documentation #813
base: main
Are you sure you want to change the base?
Update links to point to new home of cf-plot documentation #813
Conversation
Used command and then manually checked URL for a few cases: find . -type f | xargs sed -i 's~http://ajheaps.github.io/cf-plot/~ https://ncas-cms.github.io/cf-plot/build/~g'
Used equivalent find and sed command to previous commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sadie, sanity prevails! But do we want the "build" in the URLs? Should we have (e.g.) https://ncas-cms.github.io/cf-plot/gopen.html
, a la cf-python?
Good spot. Ideally not, but I like to separate out the built and source documentation into their own directories to keep them self-contained for dev and building and to do so I need to put the built content into a different directory. So unless I can find a way to point the root from |
Hi Sadie - could you structure it like we do in cf-python, perhaps? |
I could, but then I would have to go and change all of the links I've updated with Having a separate For now I think we have three options on this note:
I prefer (1) since then I'll be getting something done I have been putting off and we will both be happy (I think?), what do you think? |
I should add, it's a shame GitHub Pages doesn't let me serve the docs site from |
Oh wait! I have a new fourth option that is probably the best way forward:
|
As I realised when guiding our summer student this week, the cf-python documentation still links to the old cf-plot documentation under the 'ajheaps' userspace, except for the README. I had updated the README some months ago but neglected to do a full sweep of the codebase to update all references to the old cf-plot docs, so here is that mass update.
@davidhassell, feel free to just sanity check as a review since this is very self-contained, specific and non-controversial. Thanks.