Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect result units for some differential operators #808

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

davidhassell
Copy link
Collaborator

Fixes #807

@davidhassell davidhassell added the bug Something isn't working label Sep 2, 2024
@davidhassell davidhassell added this to the NEXT VERSION milestone Sep 2, 2024
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, please merge!

@@ -14262,6 +14279,28 @@ def derivative(
at the non-cyclic boundaries. By default missing
values are set at non-cyclic boundaries.

ignore_coordinate_units: `bool`, optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clearly documented, +1.

@davidhassell
Copy link
Collaborator Author

Thanks!

@davidhassell davidhassell merged commit 807f740 into NCAS-CMS:main Sep 9, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect result units for some differential operators
2 participants