Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in cf.Field.match_by_construct #694

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Fix bug in cf.Field.match_by_construct #694

merged 2 commits into from
Sep 20, 2023

Conversation

davidhassell
Copy link
Collaborator

Fixes #691

@davidhassell davidhassell added this to the Next release milestone Sep 19, 2023
sadielbartholomew
sadielbartholomew approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot on the bug. I can confirm the PR fixes it and provides new testing to expose it pre-fix. All good, please merge.

Changelog.rst Outdated Show resolved Hide resolved
@davidhassell @sadielbartholomew
Typo
d187158 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell davidhassell merged commit 88febb7 into NCAS-CMS:main Sep 20, 2023
@davidhassell davidhassell deleted the match-by-construct branch September 20, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.15.4
Development

Successfully merging this pull request may close these issues.

cf.Field.match_by_construct always returns True for 1-d constructs whose axis is not in the data
2 participants
@davidhassell @sadielbartholomew