Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS-dev PR#65 #99

Merged
merged 12 commits into from
Jul 7, 2023
Merged

UFS-dev PR#65 #99

merged 12 commits into from
Jul 7, 2023

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Jun 26, 2023

Identical to ufs-community#1731

Contains changes from: ufs-community#1720, ufs-community#1715, ufs-community#1667

1715 causes the following RTs to fail:
rrfs_smoke_conus13km_hrrr_warm
rrfs_smoke_conus13km_hrrr_warm_2threads
rrfs_conus13km_hrrr_warm
rrfs_smoke_conus13km_radar_tten_warm
rrfs_smoke_conus13km_hrrr_warm_debug
rrfs_smoke_conus13km_hrrr_warm_debug_2threads
rrfs_conus13km_hrrr_warm_debug
rrfs_conus13km_hrrr_warm_restart_mismatch

1720 causes all RTs to fail

Associated PRs:
NCAR/fv3atm#96
NCAR/ccpp-physics#1020

XiaqiongZhou-NOAA and others added 6 commits April 28, 2023 11:29
* Update FV3 to a new version: Dycore semi-implicit solver update
…sing and combined with ufs-community#1730 WW3 update (ufs-community#1715)

* update FV3 to better handle data source for regional model LBC processing

* update WW3: PR#1730
* Update default_vars.sh to add noaacloud

* Update detect_machine.sh to add noaacloud

* Update module-setup.sh to add noaacloud env variables

* Add noaacloud and env variable to rt.sh

* Update module-setup.sh

* Create ufs_noaacloud.intel.lua

* Create ufs_common_spack.lua

* Create compile_slurm.IN_noaacloud

* Create fv3_slurm.IN_noaacloud

* Update rt_utils.sh

* Adding Requesting if statement to default_vars

adding -B option back to nccmp
* This PR is created due to the ccpp-physics update for HR2

* PBL, Convection and Microphysics Update for HR2
@grantfirl
Copy link
Collaborator Author

Failed Hera/intel tests:
cpld_control_p8_mixedmode 001 failed in check_result
cpld_control_p8_mixedmode 001 failed in run_test
cpld_control_gfsv17 002 failed in check_result
cpld_control_gfsv17 002 failed in run_test
cpld_control_p8 003 failed in check_result
cpld_control_p8 003 failed in run_test
cpld_control_qr_p8 005 failed in check_result
cpld_control_qr_p8 005 failed in run_test
cpld_2threads_p8 007 failed in check_result
cpld_2threads_p8 007 failed in run_test
cpld_decomp_p8 008 failed in check_result
cpld_decomp_p8 008 failed in run_test
cpld_mpi_p8 009 failed in check_result
cpld_mpi_p8 009 failed in run_test
cpld_control_ciceC_p8 010 failed in check_result
cpld_control_ciceC_p8 010 failed in run_test
cpld_control_c192_p8 011 failed in check_result
cpld_control_c192_p8 011 failed in run_test
cpld_bmark_p8 013 failed in run_test
cpld_control_noaero_p8 015 failed in check_result
cpld_control_noaero_p8 015 failed in run_test
cpld_control_nowave_noaero_p8 016 failed in check_result
cpld_control_nowave_noaero_p8 016 failed in run_test
cpld_debug_p8 017 failed in check_result
cpld_debug_p8 017 failed in run_test
cpld_debug_noaero_p8 018 failed in check_result
cpld_debug_noaero_p8 018 failed in run_test
cpld_control_noaero_p8_agrid 019 failed in check_result
cpld_control_noaero_p8_agrid 019 failed in run_test
cpld_control_c48 020 failed in check_result
cpld_control_c48 020 failed in run_test
cpld_warmstart_c48 021 failed in check_result
cpld_warmstart_c48 021 failed in run_test
cpld_control_p8_faster 023 failed in check_result
cpld_control_p8_faster 023 failed in run_test
control_flake 024 failed in check_result
control_flake 024 failed in run_test
control_CubedSphereGrid 025 failed in check_result
control_CubedSphereGrid 025 failed in run_test
control_CubedSphereGrid_parallel 026 failed in check_result
control_CubedSphereGrid_parallel 026 failed in run_test
control_latlon 027 failed in check_result
control_latlon 027 failed in run_test
control_wrtGauss_netcdf_parallel 028 failed in check_result
control_wrtGauss_netcdf_parallel 028 failed in run_test
control_c48 029 failed in check_result
control_c48 029 failed in run_test
control_c192 030 failed in check_result
control_c192 030 failed in run_test
control_c384 031 failed in run_test
control_c384gdas 032 failed in run_test
control_stochy 033 failed in check_result
control_stochy 033 failed in run_test
control_lndp 035 failed in check_result
control_lndp 035 failed in run_test
control_iovr4 036 failed in check_result
control_iovr4 036 failed in run_test
control_iovr5 037 failed in check_result
control_iovr5 037 failed in run_test
control_p8 038 failed in check_result
control_p8 038 failed in run_test
control_qr_p8 040 failed in check_result
control_qr_p8 040 failed in run_test
control_decomp_p8 042 failed in check_result
control_decomp_p8 042 failed in run_test
control_2threads_p8 043 failed in check_result
control_2threads_p8 043 failed in run_test
control_p8_lndp 044 failed in check_result
control_p8_lndp 044 failed in run_test
control_p8_rrtmgp 045 failed in check_result
control_p8_rrtmgp 045 failed in run_test
control_p8_mynn 046 failed in check_result
control_p8_mynn 046 failed in run_test
merra2_thompson 047 failed in check_result
merra2_thompson 047 failed in run_test
regional_control 048 failed in check_result
regional_control 048 failed in run_test
regional_control_qr 050 failed in check_result
regional_control_qr 050 failed in run_test
regional_decomp 052 failed in check_result
regional_decomp 052 failed in run_test
regional_2threads 053 failed in check_result
regional_2threads 053 failed in run_test
regional_noquilt 054 failed in check_result
regional_noquilt 054 failed in run_test
regional_netcdf_parallel 055 failed in check_result
regional_netcdf_parallel 055 failed in run_test
regional_2dwrtdecomp 056 failed in check_result
regional_2dwrtdecomp 056 failed in run_test
regional_wofs 057 failed in check_result
regional_wofs 057 failed in run_test
rap_control 058 failed in check_result
rap_control 058 failed in run_test
regional_spp_sppt_shum_skeb 059 failed in check_result
regional_spp_sppt_shum_skeb 059 failed in run_test
rap_decomp 060 failed in check_result
rap_decomp 060 failed in run_test
rap_2threads 061 failed in check_result
rap_2threads 061 failed in run_test
rap_sfcdiff 063 failed in check_result
rap_sfcdiff 063 failed in run_test
rap_sfcdiff_decomp 064 failed in check_result
rap_sfcdiff_decomp 064 failed in run_test
hrrr_control 066 failed in check_result
hrrr_control 066 failed in run_test
hrrr_control_decomp 067 failed in check_result
hrrr_control_decomp 067 failed in run_test
hrrr_control_2threads 068 failed in check_result
hrrr_control_2threads 068 failed in run_test
rrfs_v1beta 070 failed in check_result
rrfs_v1beta 070 failed in run_test
rrfs_v1nssl 071 failed in check_result
rrfs_v1nssl 071 failed in run_test
rrfs_v1nssl_nohailnoccn 072 failed in check_result
rrfs_v1nssl_nohailnoccn 072 failed in run_test
rrfs_smoke_conus13km_hrrr_warm 073 failed in check_result
rrfs_smoke_conus13km_hrrr_warm 073 failed in run_test
rrfs_smoke_conus13km_hrrr_warm_2threads 074 failed in check_result
rrfs_smoke_conus13km_hrrr_warm_2threads 074 failed in run_test
rrfs_conus13km_hrrr_warm 075 failed in check_result
rrfs_conus13km_hrrr_warm 075 failed in run_test
rrfs_smoke_conus13km_radar_tten_warm 076 failed in check_result
rrfs_smoke_conus13km_radar_tten_warm 076 failed in run_test
control_csawmg 078 failed in check_result
control_csawmg 078 failed in run_test
control_csawmgt 079 failed in check_result
control_csawmgt 079 failed in run_test
control_ras 080 failed in check_result
control_ras 080 failed in run_test
control_wam 081 failed in check_result
control_wam 081 failed in run_test
control_p8_faster 082 failed in check_result
control_p8_faster 082 failed in run_test
regional_control_faster 083 failed in check_result
regional_control_faster 083 failed in run_test
rrfs_smoke_conus13km_hrrr_warm_debug 084 failed in check_result
rrfs_smoke_conus13km_hrrr_warm_debug 084 failed in run_test
rrfs_smoke_conus13km_hrrr_warm_debug_2threads 085 failed in check_result
rrfs_smoke_conus13km_hrrr_warm_debug_2threads 085 failed in run_test
rrfs_conus13km_hrrr_warm_debug 086 failed in check_result
rrfs_conus13km_hrrr_warm_debug 086 failed in run_test
control_CubedSphereGrid_debug 087 failed in check_result
control_CubedSphereGrid_debug 087 failed in run_test
control_wrtGauss_netcdf_parallel_debug 088 failed in check_result
control_wrtGauss_netcdf_parallel_debug 088 failed in run_test
control_stochy_debug 089 failed in check_result
control_stochy_debug 089 failed in run_test
control_lndp_debug 090 failed in check_result
control_lndp_debug 090 failed in run_test
control_csawmg_debug 091 failed in check_result
control_csawmg_debug 091 failed in run_test
control_csawmgt_debug 092 failed in check_result
control_csawmgt_debug 092 failed in run_test
control_ras_debug 093 failed in check_result
control_ras_debug 093 failed in run_test
control_diag_debug 094 failed in check_result
control_diag_debug 094 failed in run_test
control_debug_p8 095 failed in check_result
control_debug_p8 095 failed in run_test
regional_debug 096 failed in check_result
regional_debug 096 failed in run_test
rap_control_debug 097 failed in check_result
rap_control_debug 097 failed in run_test
hrrr_control_debug 098 failed in check_result
hrrr_control_debug 098 failed in run_test
rap_unified_drag_suite_debug 099 failed in check_result
rap_unified_drag_suite_debug 099 failed in run_test
rap_diag_debug 100 failed in check_result
rap_diag_debug 100 failed in run_test
rap_cires_ugwp_debug 101 failed in check_result
rap_cires_ugwp_debug 101 failed in run_test
rap_unified_ugwp_debug 102 failed in check_result
rap_unified_ugwp_debug 102 failed in run_test
rap_lndp_debug 103 failed in check_result
rap_lndp_debug 103 failed in run_test
rap_progcld_thompson_debug 104 failed in check_result
rap_progcld_thompson_debug 104 failed in run_test
rap_noah_debug 105 failed in check_result
rap_noah_debug 105 failed in run_test
rap_sfcdiff_debug 106 failed in check_result
rap_sfcdiff_debug 106 failed in run_test
rap_noah_sfcdiff_cires_ugwp_debug 107 failed in check_result
rap_noah_sfcdiff_cires_ugwp_debug 107 failed in run_test
rrfs_v1beta_debug 108 failed in check_result
rrfs_v1beta_debug 108 failed in run_test
rap_clm_lake_debug 109 failed in check_result
rap_clm_lake_debug 109 failed in run_test
rap_flake_debug 110 failed in check_result
rap_flake_debug 110 failed in run_test
control_wam_debug 111 failed in check_result
control_wam_debug 111 failed in run_test
regional_spp_sppt_shum_skeb_dyn32_phy32 112 failed in check_result
regional_spp_sppt_shum_skeb_dyn32_phy32 112 failed in run_test
rap_control_dyn32_phy32 113 failed in check_result
rap_control_dyn32_phy32 113 failed in run_test
hrrr_control_dyn32_phy32 114 failed in check_result
hrrr_control_dyn32_phy32 114 failed in run_test
rap_2threads_dyn32_phy32 115 failed in check_result
rap_2threads_dyn32_phy32 115 failed in run_test
hrrr_control_2threads_dyn32_phy32 116 failed in check_result
hrrr_control_2threads_dyn32_phy32 116 failed in run_test
hrrr_control_decomp_dyn32_phy32 117 failed in check_result
hrrr_control_decomp_dyn32_phy32 117 failed in run_test
rap_control_dyn64_phy32 120 failed in check_result
rap_control_dyn64_phy32 120 failed in run_test
rap_control_debug_dyn32_phy32 121 failed in check_result
rap_control_debug_dyn32_phy32 121 failed in run_test
hrrr_control_debug_dyn32_phy32 122 failed in check_result
hrrr_control_debug_dyn32_phy32 122 failed in run_test
rap_control_dyn64_phy32_debug 123 failed in check_result
rap_control_dyn64_phy32_debug 123 failed in run_test
hafs_regional_atm 124 failed in check_result
hafs_regional_atm 124 failed in run_test
hafs_regional_atm_thompson_gfdlsf 125 failed in check_result
hafs_regional_atm_thompson_gfdlsf 125 failed in run_test
hafs_regional_atm_ocn 126 failed in check_result
hafs_regional_atm_ocn 126 failed in run_test
hafs_regional_atm_wav 127 failed in check_result
hafs_regional_atm_wav 127 failed in run_test
hafs_regional_atm_ocn_wav 128 failed in check_result
hafs_regional_atm_ocn_wav 128 failed in run_test
hafs_regional_1nest_atm 129 failed in check_result
hafs_regional_1nest_atm 129 failed in run_test
hafs_regional_telescopic_2nests_atm 130 failed in check_result
hafs_regional_telescopic_2nests_atm 130 failed in run_test
hafs_global_1nest_atm 131 failed in check_result
hafs_global_1nest_atm 131 failed in run_test
hafs_global_multiple_4nests_atm 132 failed in check_result
hafs_global_multiple_4nests_atm 132 failed in run_test
hafs_regional_specified_moving_1nest_atm 133 failed in check_result
hafs_regional_specified_moving_1nest_atm 133 failed in run_test
hafs_regional_storm_following_1nest_atm 134 failed in check_result
hafs_regional_storm_following_1nest_atm 134 failed in run_test
hafs_regional_storm_following_1nest_atm_ocn 135 failed in check_result
hafs_regional_storm_following_1nest_atm_ocn 135 failed in run_test
hafs_global_storm_following_1nest_atm 136 failed in check_result
hafs_global_storm_following_1nest_atm 136 failed in run_test
hafs_regional_storm_following_1nest_atm_ocn_debug 137 failed in check_result
hafs_regional_storm_following_1nest_atm_ocn_debug 137 failed in run_test
hafs_regional_storm_following_1nest_atm_ocn_wav 138 failed in check_result
hafs_regional_storm_following_1nest_atm_ocn_wav 138 failed in run_test
hafs_regional_docn 139 failed in check_result
hafs_regional_docn 139 failed in run_test
hafs_regional_docn_oisst 140 failed in check_result
hafs_regional_docn_oisst 140 failed in run_test
control_p8_atmlnd_sbs 159 failed in check_result
control_p8_atmlnd_sbs 159 failed in run_test
atmwav_control_noaero_p8 160 failed in check_result
atmwav_control_noaero_p8 160 failed in run_test
control_atmwav 161 failed in check_result
control_atmwav 161 failed in run_test
atmaero_control_p8 162 failed in check_result
atmaero_control_p8 162 failed in run_test
atmaero_control_p8_rad 163 failed in check_result
atmaero_control_p8_rad 163 failed in run_test
atmaero_control_p8_rad_micro 164 failed in check_result
atmaero_control_p8_rad_micro 164 failed in run_test
regional_atmaq 165 failed in check_result
regional_atmaq 165 failed in run_test
regional_atmaq_debug 166 failed in check_result
regional_atmaq_debug 166 failed in run_test
regional_atmaq_faster 167 failed in check_result
regional_atmaq_faster 167 failed in run_test

@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: gnu
Job: BL
Please make changes and add the following label back: hera-gnu-BL

@mkavulich
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: gnu
Job: BL
[BL] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1408568096/20230628180727/ufs-weather-model
Please make changes and add the following label back: hera-gnu-BL

@grantfirl
Copy link
Collaborator Author

@mkavulich I'm manually running Hera/intel right now (creating new baseline, and testing against them).

@mkavulich
Copy link
Collaborator

@grantfirl I'm working on getting the automated tests up and running, sorry about that. We can discuss at today's meeting.

@grantfirl grantfirl requested a review from mkavulich June 30, 2023 20:39
@grantfirl
Copy link
Collaborator Author

@mkavulich This and associated PRs are ready to review. Once I get acceptance, I'll go ahead and start the merge sequence and start testing on the next one (#100)

Copy link
Collaborator

@mkavulich mkavulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a soap-box comment

@@ -43,7 +43,14 @@ elif [[ $MACHINE_ID = cheyenne* ]] ; then
source /glade/u/apps/ch/modulefiles/default/localinit/localinit.sh
fi
module purge


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hacky and terrible. Why are testing scripts trying to automatically determine what machine they are being run on instead of just being specified on the command line?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should probably have gone under "detect_machine.sh", but it still stands

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this has been around for as long as I've been involved with the GFS. I suppose that it's handy for the end user -- one less thing to specify when running tests.

@grantfirl grantfirl merged commit 6901a5f into NCAR:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants