Fix area logic in SCM #544
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2024 17:13
hertneky
requested review from
dustinswales,
grantfirl and
mkavulich
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly assign area from the DEPHY forcing file. -> pulled out of the "if surfaceForcingLSM = lsm" statement since some canned cases have "surface_forcing_lsm = none".
Allow column_area to override scm_state%area if it is defined in the case_confil nml. When not defined in the case_config, scm_state%area is zero. In this case, use the default case area from the DEPHY forcing file.
@grantfirl @dustinswales Should there also be logic if area is not present in DEPHY file and not in the nml? (probably) Should there be some logging added to write what area is being used? LMK and I can add.
#540