Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce GNU Compilation Warnings #1048

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Reduce GNU Compilation Warnings #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
63e468b
Adding w3emc wrapper to reduce the number of warnings for calling the…
scrasmussen Jan 13, 2024
c024cfe
Switching to newer NetCDF Fortran 90 interfaces to reduce type mismat…
scrasmussen Jan 13, 2024
50dda7d
Checking to define macro CCPP only if it is not defined reduces macro…
scrasmussen Jan 13, 2024
2d43fc8
Setting true and false integer parameters to fix type conversion warning
scrasmussen Jan 13, 2024
4433e61
Fixing 'Warning: Deleted feature: Start expression in DO loop at (1) …
scrasmussen Jan 17, 2024
e0e6946
More accurate variable names for setting use_lake_model and comment fix
scrasmussen Jan 18, 2024
effeeb8
removed w3emc changes, this is fixed with a different method in an up…
scrasmussen May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion physics/GWD/cires_tauamf_data.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ subroutine tau_amf_interp(me, master, im, idate, fhour, j1_tau,j2_tau, ddy_j1, d
end subroutine tau_amf_interp

subroutine gfs_idate_calendar(idate, fhour, ddd, fddd)

use machine, only: kind_phys
implicit none
! input
Expand Down
6 changes: 3 additions & 3 deletions physics/Interstitials/UFS_SCM_NEPTUNE/GFS_time_vary_pre.scm.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,14 @@
[nsswr]
standard_name = number_of_timesteps_between_shortwave_radiation_calls
long_name = number of timesteps between shortwave radiation calls
units =
units =
dimensions = ()
type = integer
intent = in
[nslwr]
standard_name = number_of_timesteps_between_longwave_radiation_calls
long_name = number of timesteps between longwave radiation calls
units =
units =
dimensions = ()
type = integer
intent = in
Expand Down Expand Up @@ -176,7 +176,7 @@
[ipt]
standard_name = index_of_horizontal_gridpoint_for_debug_output
long_name = horizontal index for point used for diagnostic printout
units = index
units = index
dimensions = ()
type = integer
intent = out
Expand Down
38 changes: 19 additions & 19 deletions physics/Interstitials/UFS_SCM_NEPTUNE/iccninterp.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,37 +23,37 @@ SUBROUTINE read_cidata (me, master)
integer, intent(in) :: me
integer, intent(in) :: master
!--- locals
integer :: i, n, k, ncid, varid,j,it
integer :: i, n, k, ncid, varid, j, it, stat
real(kind=kind_phys), allocatable, dimension(:) :: hyam,hybm
real(kind=4), allocatable, dimension(:,:,:) :: ci_ps

allocate (hyam(kcipl), hybm(kcipl), ci_ps(lonscip,latscip,timeci))
allocate (ciplin(lonscip,latscip,kcipl,timeci))
allocate (ccnin(lonscip,latscip,kcipl,timeci))
allocate (ci_pres(lonscip,latscip,kcipl,timeci))
call nf_open("cam5_4_143_NAAI_monclimo2.nc", NF90_NOWRITE, ncid)
call nf_inq_varid(ncid, "lat", varid)
call nf_get_var(ncid, varid, ci_lat)
call nf_inq_varid(ncid, "lon", varid)
call nf_get_var(ncid, varid, ci_lon)
call nf_inq_varid(ncid, "PS", varid)
call nf_get_var(ncid, varid, ci_ps)
call nf_inq_varid(ncid, "hyam", varid)
call nf_get_var(ncid, varid, hyam)
call nf_inq_varid(ncid, "hybm", varid)
call nf_get_var(ncid, varid, hybm)
call nf_inq_varid(ncid, "NAAI", varid)
call nf_get_var(ncid, varid, ciplin)
stat = nf90_open("cam5_4_143_NAAI_monclimo2.nc", NF90_NOWRITE, ncid)
stat = nf90_inq_varid(ncid, "lat", varid)
stat = nf90_get_var(ncid, varid, ci_lat)
stat = nf90_inq_varid(ncid, "lon", varid)
stat = nf90_get_var(ncid, varid, ci_lon)
stat = nf90_inq_varid(ncid, "PS", varid)
stat = nf90_get_var(ncid, varid, ci_ps)
stat = nf90_inq_varid(ncid, "hyam", varid)
stat = nf90_get_var(ncid, varid, hyam)
stat = nf90_inq_varid(ncid, "hybm", varid)
stat = nf90_get_var(ncid, varid, hybm)
stat = nf90_inq_varid(ncid, "NAAI", varid)
stat = nf90_get_var(ncid, varid, ciplin)
do it = 1,timeci
do k=1, kcipl
ci_pres(:,:,k,it)=hyam(k)*1.e5+hybm(k)*ci_ps(:,:,it)
end do
end do
call nf_close(ncid)
call nf_open("cam5_4_143_NPCCN_monclimo2.nc", NF90_NOWRITE, ncid)
call nf_inq_varid(ncid, "NPCCN", varid)
call nf_get_var(ncid, varid, ccnin)
call nf_close(ncid)
stat = nf90_close(ncid)
stat = nf90_open("cam5_4_143_NPCCN_monclimo2.nc", NF90_NOWRITE, ncid)
stat = nf90_inq_varid(ncid, "NPCCN", varid)
stat = nf90_get_var(ncid, varid, ccnin)
stat = nf90_close(ncid)
!---
deallocate (hyam, hybm, ci_ps)
if (me == master) then
Expand Down
7 changes: 4 additions & 3 deletions physics/Interstitials/UFS_SCM_NEPTUNE/scm_sfc_flux_spec.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ subroutine scm_sfc_flux_spec_run (im, u1, v1, z1, t1, q1, p1, roughness_length,
integer, intent(out) :: errflg

integer :: i
integer, parameter :: lake_model_on = 1, lake_model_off = 0 ! to match type of use_lake_model

real(kind=kind_phys) :: rho, q1_non_neg, w_thv1, rho_cp_inverse, rho_hvap_inverse, Obukhov_length, thv1, tvs, &
dtv, adtv, wind10m, u_fraction, roughness_length_m
Expand Down Expand Up @@ -212,12 +213,12 @@ subroutine scm_sfc_flux_spec_run (im, u1, v1, z1, t1, q1, p1, roughness_length,
do i = 1, im
if ((wet(i) .or. icy(i)) .and. lakefrac(i) > 0.0_kind_phys) then
if (lkm == 1 .and. lakefrac(i) >= 0.15 .and. lakedepth(i) > 1.0_kind_phys) then
use_lake_model(i) = 1
use_lake_model(i) = lake_model_on
else
use_lake_model(i) = 0
use_lake_model(i) = lake_model_off
endif
else
use_lake_model(i) = 0
use_lake_model(i) = lake_model_off
endif
enddo
!
Expand Down
1 change: 0 additions & 1 deletion physics/MP/Morrison_Gettelman/aerinterp.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
!! This module contain subroutines of reading and interpolating
!! aerosol data for MG microphysics.
module aerinterp

implicit none

private read_netfaer
Expand Down
2 changes: 1 addition & 1 deletion physics/SFC_Models/Lake/CLM/clm_lake.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5625,7 +5625,7 @@ SUBROUTINE lakeini(kdt, ISLTYP, gt0, snowd,
! initial t_soisno3d
! in snow
if(snowdp2d(i) > 0.) then
do k = snl2d(i)+1, 0
do k = nint(snl2d(i))+1, 0
t_soisno3d(i,k) =min(tfrz,tsfc(i))
enddo
endif
Expand Down
2 changes: 2 additions & 0 deletions physics/SFC_Models/Land/Noahmp/module_sf_noahmp_glacier.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#ifndef CCPP
#define CCPP
#endif
!> \file module_sf_noahmp_glacier.F90
!! This file contains the NoahMP Glacier scheme.

Expand Down
2 changes: 2 additions & 0 deletions physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#ifndef CCPP
#define CCPP
#endif
!> \file module_sf_noahmplsm.F90
!! This file contains the NoahMP land surface model.

Expand Down
2 changes: 2 additions & 0 deletions physics/SFC_Models/Land/Noahmp/noahmpdrv.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#ifndef CCPP
#define CCPP
#endif
!> \file noahmpdrv.F90
!! This file contains the NoahMP land surface scheme driver.

Expand Down
Loading