UFS-dev PR#88 #1032
UFS-dev PR#88 #1032
Conversation
land surface upgrades for HR2
grantfirl
requested review from
gthompsnWRF,
RuiyuSun,
AndersJensen-NOAA,
Qingfu-Liu and
dustinswales
as code owners
grantfirl
requested review from
mkavulich
and removed request for
dustinswales,
gthompsnWRF,
RuiyuSun and
AndersJensen-NOAA
| @@ -3400,8 +3400,8 @@ subroutine mp_thompson (qv1d, qc1d, qi1d, qr1d, qs1d, qg1d, ni1d, & | |||
| tcond(k) = (5.69 + 0.0168*tempc)*1.0E-5 * 418.936 | |||
| ocp(k) = 1./(Cp*(1.+0.887*qv(k))) | |||
| lvt2(k)=lvap(k)*lvap(k)*ocp(k)*oRv*otemp*otemp | |||
|
|
|||
| nwfa(k) = MAX(11.1E6*rho(k), (nwfa1d(k) + nwfaten(k)*DT)*rho(k)) | |||
| if (is_aerosol_aware) & | |||
There was a problem hiding this comment.
Others should weigh in here -- would a better strategy be to make nwfa and nifa both optional variables for module_mp_thompson?
There was a problem hiding this comment.
Personally, I like what your propose.
"is_aerosol_aware" could be replaced by (present(nwfa) .and. prsent(nifa)), and it would be self consistent.
There was a problem hiding this comment.
Others should weigh in here -- would a better strategy be to make nwfa and nifa both optional variables for module_mp_thompson?
It looks like they already are optional variables but that an additional logical is used to control their use. Perhaps someone knows why the logical is still needed?
Regardless, we probably shouldn't change this particular PR since this is supposed to be identical to ufs/dev PR88. If changes need to be made, they should be made to a new PR into ufs/dev.
Identical to ufs-community#88