Options to enforce KHTR_MIN and KHTH_MIN in the whole water column and fix naming inconsistency #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter KHTR_USE_EBT_STRUCT was introduced with an incorrect variable name within the local control structure. The variable was named KhTh_use_ebt_struct, indicating thickness diffusivity, instead of the correct KhTr_use_ebt_struct, which indicates tracer diffusivity. This commit rectifies the naming inconsistency.
This commit introduces a new parameter, FULL_DEPTH_KHTR_MIN, which enforces a user-specified minimum diffusivity (KHTR_MIN) to be applied throughout the entire water column, instead of only at the surface. This option is available only when KHTR_USE_EBT_STRUCT=True and KHTR_MIN > 0.
This commit introduces a new parameter, FULL_DEPTH_KHTH_MIN, which enforces a user-specified minimum diffusivity (KHTH_MIN) to be applied throughout the entire water column instead of only at the surface. This option is available only when KHTH_USE_EBT_STRUCT=True and KHTH_MIN > 0.
alperaltuntas
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option to enforce
KHTR_MINin the whole water column (967908d): introduces a new parameter,FULL_DEPTH_KHTR_MIN, which enforces a user-specified minimum diffusivity (KHTR_MIN) to be applied throughout the entire water column, instead of only at the surface. This option is available only whenKHTR_USE_EBT_STRUCT=TrueandKHTR_MIN > 0.Option to enforce
KHTH_MINin the whole water column (0c63d96): introduces a new parameter,FULL_DEPTH_KHTH_MIN, which enforces a user-specified minimum diffusivity (KHTH_MIN) to be applied throughout the entire water column instead of only at the surface. This option is available only whenKHTH_USE_EBT_STRUCT=TrueandKHTH_MIN > 0.Rename KhTh_use_ebt_struct to KhTr_use_ebt_struct (8d018d0): The parameter
KHTR_USE_EBT_STRUCTwas introduced with an incorrect variable name within the local control structure. The variable was namedKhTh_use_ebt_struct, indicating thickness diffusivity, instead of the correctKhTr_use_ebt_struct, which indicates tracer diffusivity. This commit rectifies the naming inconsistency.New parameters:
FULL_DEPTH_KHTR_MINFULL_DEPTH_KHTH_MINThis PR does not change answers in the NCAR pr_mom tests.