+Reproducing KPP_smooth_BLD when KPP%N_SMOOTH > 1 #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperaltuntas
requested changes
Jul 12, 2024
Revised KPP_smooth_BLD() to reproduce across processor count and layout when USE_KPP is true and KPP%N_SMOOTH > 1. The specific changes include adding a variable with the total ocean depth before doing the iterations, doing a halo update on this total ocean depth, marching in the working do-loop size with successive iterations, and moving the code to calculate CS%kOBL into a separate loop that is exercised after all of the iterations for the smoothing passes on CS%OBLdepth. This commit will change answers (so that they reproduce across processor count and layout) when USE_KPP is true and KPP%N_SMOOTH >= 2, but it gives bitwise identical answers when KPP%N_SMOOTH <= 1.
Hallberg-NOAA
force-pushed
the
reproducing_KPP_smooth_BLD
branch
from
a26a126
to
920093a
Compare
alperaltuntas
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised KPP_smooth_BLD() to reproduce across processor count and layout when USE_KPP is true and KPP%N_SMOOTH > 1. The specific changes include adding a variable with the total ocean depth before doing the iterations, doing a halo update on this total ocean depth, marching in the working do-loop size with successive iterations, and moving the code to calculate CS%kOBL into a separate loop that is exercised after all of the iterations for the smoothing passes on CS%OBLdepth. This commit will change answers (so that they reproduce across processor count and layout) when USE_KPP is true and KPP%N_SMOOTH >= 2, but it gives bitwise identical answers when KPP%N_SMOOTH <= 1.