Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(usePathname): prevent duplication of subpath in pathname #1333

Merged
merged 2 commits into from
Dec 17, 2024
+19 −2
Merged

fix(usePathname): prevent duplication of subpath in pathname #1333

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1a13af
fix(usePathname): prevent duplication of subpath in pathname
vgeorge Dec 17, 2024
5c0bbbb
fix(usePathname): extract app pathname when PUBLIC_URL is a full URL
vgeorge Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/scripts/utils/use-pathname.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,18 @@ import { useEffect, useState } from 'react';
*/
export const usePathname = () => {
const [pathname, setPathname] = useState(
typeof window !== 'undefined' ? window.location.pathname : ''
typeof window !== 'undefined'
? window.location.pathname.replace(process.env.PUBLIC_URL ?? '', '')
: ''
);

useEffect(() => {
if (typeof window === 'undefined') return;

const updatePathname = () => {
setPathname(window.location.pathname);
setPathname(
window.location.pathname.replace(process.env.PUBLIC_URL ?? '', '')
vgeorge marked this conversation as resolved.
Show resolved Hide resolved
);
};

// Listen to popstate events (back/forward navigation)
Expand Down
Loading