chore: Upgrade jest and testing-library dependencies #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they should be imported in the setup
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
we should clean up the issues behind those warnings and set the rules back to the recommended . Changing it to warn now only to limit the scope of the PR and not having to touch legacy code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1322
As part of general maintenance, it's important to keep our dependencies up to date.
The main reason for this upgrade was to address the deprecation warning related to
renderin our logs. By using the updated Testing Library, we remove unnecessary noise from the test output.While making this change, a few other issues have surfaced, but they are actually helpful:
We now see browser warnings, such as:
Warning: validateDOMNesting(...): <ul> cannot appear as a descendant of <p>.These are actionable errors that highlight areas where our HTML structure violates best practices.
One issue seems to stem from TypeScript. This could require adjustments to our TypeScript configuration. Is someone available to help investigate and resolve this?Issue resolved by downgrading some @types/react and @types/react-dom. I moved all the types dependencies into the devDependencies now, so it is easier to keep track of them.
Steps to review:
(optional) Remove the node_modules directory.
(optional) Reinstall dependencies with the updated versions
Run the test suite:
yarn test