fix: 1135 wiring up veda config #1320
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
snmln
changed the base branch from
main
to
1135-Refactor-Layout-Components-Footer
| const createNavElement = (navItems, linkClasses) => { | ||
| //removing 'dropdown' items from array | ||
| let cleanedNavItems = navItems.filter((a) => { | ||
| if (a.type !== 'dropdown') { | ||
| return a; | ||
| } | ||
| }); | ||
|
|
||
| return cleanedNavItems.map((item) => { | ||
| switch (item.type) { | ||
| case NavItemType.ACTION: | ||
| return <NavItemCTA item={item} />; | ||
|
|
||
| case NavItemType.EXTERNAL_LINK: | ||
| return ( | ||
| <a className={linkClasses} href={item.to} key={item.id}> | ||
| {item.title} | ||
| </a> | ||
| ); | ||
| case NavItemType.INTERNAL_LINK: | ||
| return ( | ||
| <a className={linkClasses} href={item.to} key={item.id}> | ||
| {item.title} | ||
| </a> | ||
| ); | ||
|
|
||
| default: | ||
| return <></>; | ||
| } | ||
| }); |
There was a problem hiding this comment.
I know we have similar functionality from the header work here: https://github.com/NASA-IMPACT/veda-ui/blob/main/app/scripts/components/common/page-header/nav/create-dynamic-nav-menu-list.tsx
The issue is that the header styling is implicit to this function. We should reuse this functionality but expand it to accept different stylings. I need to look into this a little more to wrap my head around it better. But based on my current understanding that seems like a decent amount of work to accomplish.
My opinion (with my current understanding) is that we note it and create a dedicated clean up ticket to integrate that styling functionality since this will bleed into the header work that was just created.
@AliceR With your familiarity with the functionality what are your thoughts?
There was a problem hiding this comment.
you could move the nav directory with createDynamicNavMenuList et al outside of header to be accessible to header&footer and still use the nav-item-link and CTA components like createDynamicNavMenuList already does but make it take in the className now as a param and pass it down as a prop to the nav link components. I dont think footer will need to worry about dropdowns. For CTA, you could make the style a prop as well but default it.
That doesn't have to be done here though, feel free to leave an @TODO note in the code noting the need to consolidate and create a ticket for it 👍🏼
There was a problem hiding this comment.
Sweet I have gone ahead and created a new issue: #1323 for this.
AliceR
added
the
design system change
snmln
changed the title
AliceR
merged commit 8c3c769
into
1135-Refactor-Layout-Components-Footer
@AliceR I am getting the menu items wired up.