Fix payload issue #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anisbhsl
added a commit
that referenced
this pull request
Oct 24, 2023
* Add documentation for pynequa (#7) * added readme and license * added readthedocs config * added conf.py update conf update conf removed theme reset * fix sphinx docs * fix typo * added in gitignore * Feature: Add github action workflows and tests (#8) * added build check action * minor changes * changes in markdowns * build on push only * added mock and actual api unit tests * update install command for pypi * add release version * added usage example and minor fixes (#10) * added engine.sql method (#13) * Add classmethod for initializing Sinequa class (#18) * added classmethod for initializing Sinequa class * updated docs * don't send empty params in payload * don't send empty params in payload (#20) * fix error with payload generation * Feature: Update datamodels (#21) * updated datamodels to use dataclass * resolved comments * updated metadata in docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Fix:
Sending empty params in payload was causing Sinequa to give wrong responses with fields that didn't make any sense.
This bugfix limits pynequa from sending any such empty params in the payload.