Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Python Starter Kit write-up to include various scanning improvements … #147

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Update Python Starter Kit write-up to include various scanning improvements … #147

merged 1 commit into from
Mar 26, 2024

Conversation

ingyhere
Copy link
Contributor

Purpose

  • Minor text edits to promote clarity
  • Update writeup to reference latest scanning GitHub Actions

Proposed Changes

  • [CHANGE] README contents
  • [ADD] References to scanning GitHub Actions -- SCRUB, Detect Secrets and PyLint

Issues

Testing

  • Locally tested with sample repository: full scan, pre-commit hook
  • Text validated for consistency on Git web site

@ingyhere ingyhere requested review from riverma, jpl-jengelke and a team March 19, 2024 16:39
@ingyhere ingyhere self-assigned this Mar 19, 2024
@ingyhere ingyhere requested a review from yunks128 March 19, 2024 16:43
jpl-jengelke
jpl-jengelke approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@jpl-jengelke jpl-jengelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather small PR with targeted, but impactful changes.

nutjob4life
nutjob4life approved these changes Mar 26, 2024
View reviewed changes
Copy link

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@riverma riverma added the software lifecycle Process improvements involving developing, testing, integrating, deploying software label Mar 26, 2024
@ingyhere ingyhere merged commit e27ee43 into main Mar 26, 2024
2 checks passed
@ingyhere ingyhere deleted the issue_142 branch March 26, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nutjob4life nutjob4life nutjob4life approved these changes

@riverma riverma riverma approved these changes

@jpl-jengelke jpl-jengelke jpl-jengelke approved these changes

@yunks128 yunks128 Awaiting requested review from yunks128

Assignees

@ingyhere ingyhere

Labels
software lifecycle Process improvements involving developing, testing, integrating, deploying software
Projects
SLIM Planning Board
Status: ✅ Work Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ingyhere @nutjob4life @riverma @jpl-jengelke