Refactor GameCard for better maintainability and readability #121
Conversation
- This is groundwork for issues and that I will fix. I will split this up as several pull requests, for easier reviewing. - Disables the `opening_brace` swiftlint rule. Reasoning is simple: Xcode 16 has swift-format built-in and the default config clashes with this rule. Xcode's setting is the obvious priority as it improves consistency through an easy to use tool. - Refactors the code of `GameCard.swift`. It's now much faster to find each component in this view that has many dependencies. This work lays out the code and allows easier debugging. **Zero behavior is changed.**
|
This makes the file less messy, but in turn makes it more difficult to navigate and directly modify logic affecting its presentation. There's also not much point to having variables if they don't actually vary and are only going to be called once |
|
i fully disagree. this is much better and how any professional swiftui ui is built. i recommend you reassess this. being called once doesn't mean you shouldn't make the body clean. any future iteration is much easier to change when everything is broken down into smaller pieces. swiftui itself works better as well. take my professional over yours in this case and trust i know better. |
|
@marcusziade Alright, will do. I'll reimplement this change shortly, just fixing up some minor errors in some of the other PRs |
This is groundwork for issues
[BUG] Game Thumbnail doesn't save #102
and
[BUG] Adding or deleting custom launch arguments does not save #99
that I will fix. I will split this up as several pull requests, for easier reviewing.
Disables the
opening_braceswiftlint rule. Reasoning is simple: Xcode 16 has swift-format built-in and the default config clashes with this rule. Xcode's setting is the obvious priority as it improves consistency through an easy to use tool.Refactors the code of
GameCard.swift. It's now much faster to find each component in this view that has many dependencies. This work lays out the code and allows easier debugging. Zero behavior is changed.