Skip to content

Commit

Permalink
Temporarily disable grid-row switching in LibraryView
Browse files Browse the repository at this point in the history
Refactoring of `GameListRow`, introduced in PR #115, is necessary.
  • Loading branch information
blackxfiied committed Jun 28, 2024
1 parent faf702f commit a3c145d
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 12 deletions.
4 changes: 2 additions & 2 deletions Mythic.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "-";
CODE_SIGN_STYLE = Automatic;
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 2786;
CURRENT_PROJECT_VERSION = 2788;
DEAD_CODE_STRIPPING = YES;
DEVELOPMENT_ASSET_PATHS = "\"Mythic/Preview Content\"";
DEVELOPMENT_TEAM = "";
Expand Down Expand Up @@ -772,7 +772,7 @@
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "-";
CODE_SIGN_STYLE = Automatic;
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 2786;
CURRENT_PROJECT_VERSION = 2788;
DEAD_CODE_STRIPPING = YES;
DEVELOPMENT_ASSET_PATHS = "\"Mythic/Preview Content\"";
DEVELOPMENT_TEAM = "";
Expand Down
20 changes: 13 additions & 7 deletions Mythic/Localizable.xcstrings
Original file line number Diff line number Diff line change
Expand Up @@ -4049,9 +4049,6 @@
},
"Add to favorites" : {

},
"All" : {

},
"Are you sure you want to cancel bottle creation?" : {
"localizations" : {
Expand Down Expand Up @@ -17446,6 +17443,9 @@
}
}
}
},
"Grid" : {

},
"Hello, world!" : {

Expand Down Expand Up @@ -22231,6 +22231,9 @@
}
}
}
},
"List" : {

},
"Manage containers for Windows® applications" : {
"localizations" : {
Expand Down Expand Up @@ -32377,9 +32380,6 @@
}
}
}
},
"Source" : {

},
"Status Unknown" : {
"extractionState" : "stale",
Expand Down Expand Up @@ -34684,6 +34684,9 @@
}
}
}
},
"Type" : {

},
"Unable to boot default bottle." : {
"extractionState" : "stale",
Expand Down Expand Up @@ -36602,6 +36605,9 @@
},
"Verify..." : {

},
"View" : {

},
"View all currently signed in accounts" : {
"localizations" : {
Expand Down Expand Up @@ -39287,4 +39293,4 @@
}
},
"version" : "1.0"
}
}
5 changes: 3 additions & 2 deletions Mythic/Views/Navigation/Library/Library.swift
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ struct LibraryView: View {
}

ToolbarItem(placement: .confirmationAction) {
Picker("Filter by type", systemImage: "gamecontroller", selection: $filterOptions.type) {
Picker("Type", systemImage: "gamecontroller", selection: $filterOptions.type) {
ForEach(InclusiveGameType.allCases, id: \.self) { type in
Text(type.rawValue)
}
}
}

ToolbarItem(placement: .confirmationAction) {
Picker("Filter by platform", systemImage: "desktopcomputer.and.arrow.down", selection: $filterOptions.platform) {
Picker("Platform", systemImage: "desktopcomputer.and.arrow.down", selection: $filterOptions.platform) {
ForEach(InclusiveGamePlatform.allCases, id: \.self) { platform in
Label(platform.rawValue, systemImage: {
switch platform {
Expand All @@ -76,6 +76,7 @@ struct LibraryView: View {
Label("List", systemImage: "list.triangle").tag(true)
Label("Grid", systemImage: "square.grid.2x2").tag(false)
}
.disabled(true)
}
}

Expand Down
2 changes: 1 addition & 1 deletion Mythic/Views/Unified/GameListRow.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import CachedAsyncImage
import SwiftUI

struct GameListRow: View {
struct GameListRow: View { // TODO: will redo myself
@Binding var game: Game
@EnvironmentObject var networkMonitor: NetworkMonitor
@ObservedObject private var operation: GameOperation = .shared
Expand Down

0 comments on commit a3c145d

Please sign in to comment.