Add "excludes" to Intent

[synesthesiam]

Excluding one or more entities will cause a match to fail if any of those entities are present.

[clusterfudge]

Starting off with a request for some additional documentation and perhaps some more tests.

I have some concerns about how unrelated intents may interact with each other, especially with regex entities (that have a high likelihood of over-matching and unintentionally suppressing unrelated intents).

I think this is less of an issue with the DomainIntentDeterminationEngine, but definitely a problem for uses of IntentDeterminationEngine. I was hoping that the fixes to scoring on the push to 1.0 would allow us to deprecate DomainIntentDeterminationEngine, but this make it more difficult. I think I'd like to see tests for exclusions across domains (to ensure they don't interact)

Out of band of this PR, we'll want to update the adapt docs on gitbook as well.

I would also like to see an addition to some the examples in the examples directory to demonstrate usage.

I am honestly very excited to see a new contributor!

[JarbasAl]

Hope this one isn't forgotten, still looking forward for it :)

[JarbasAl]

fingers crossed this one was closed accidentally 🤞

[synesthesiam]

I haven't had the time to get this over the finish line 🫤

[NeonDaniel]

@JarbasAl @goldyfruit Can you link some examples of this being used to confirm things function as expected? I don't see any unit test coverage so I'd like to see some examples of how its working

[goldyfruit]

@JarbasAl @goldyfruit Can you link some examples of this being used to confirm things function as expected? I don't see any unit test coverage so I'd like to see some examples of how its working

Some tests coverage are already in the PR 🥇

[goldyfruit]

Thanks @NeonDaniel 👍

[NeonDaniel]

Looking at the automation, this may also need a version bump in the PR.. I also see tests should have been triggered on PR so I'm not sure why that didn't happen

[clusterfudge]

Some tests coverage are already in the PR 🥇

Excited to see this getting some traction again! While the test added provides coverage for the full integration of excludes into IntentEngine, I was also hoping to seem something more targeted that flexes Intent.validate with exclusions, similar to what we see in IntentTest.

I think I've reasoned my way around how this will interact in a system with many intents (it should be relatively isolated to itself, though with the expected vocabulary comingling).

Also, +1 to @NeonDaniel 's note that we need a version bump here.