-
Notifications
You must be signed in to change notification settings - Fork 1.7k
add VIC nodes.js #2119
base: mercury
Are you sure you want to change the base?
add VIC nodes.js #2119
Conversation
@Victorium-org Is there any reason why your chainID doesn't match what the net_version return? |
Protocol Versions: [63 62], Network Id: 93610431, Chain Id: 4388577777 |
@Victorium-org okay cool. Do you mind syncing your branch to the mercury branch? The ci test need to pass before I can merge it. |
what i need to do now ? |
@Victorium-org merge our current mercury branch with your local one so it's in sync. That should fix the CI error. |
chainId no bip44 entry found for victorium. travis error: and currently, not a working node.
|
@gamalielhere I don't think this should be merged without SLIP44 registration. I'd recommend to remove your approval from the PR. |
@mkrufky thanks for the heads up, unfortunately, I don't think I can remove my approval. I'll hold off on merging this until it gets added to bip44 and if the node is back up. |
No description provided.