Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented a fix for #39 as I ran into the same problem.
The underlying problem for this high memory consumption is, that nodejs only runs its garbage collector as a subtask.
This subtask is never executed when running a endless loop.
To resolve the issue I've changed the worker implementation to run via a interval instead of a blocking while(true) loop.
The
VanityEth.getVanityWallet
now stops after a given amount of time, so it's not blocking forever, but gets recalled from the interval almost immediately.I'm running it on a server for a few hours now.
It's consuming max CPU, but doesn't go above ~70MB memory anymore :)