Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make buffer size configurable at compile time and set it to 8192 #74

Closed

Conversation

jcorporation
Copy link
Member

@jcorporation jcorporation commented Jul 17, 2021

edit: I notified meanwhile the default mpd output buffer is 8 MiB not 8 kiB

The libmpdclient buffer is the max length of a output line and this is not limited on server side?

But eventually this patch is even so useful?

Or I struggling with all of this?

@MaxKellermann
Copy link
Member

I don't think a compile-time option is a good idea. Rarely ever will people do their own libmpdclient build, and adding that compile-time knob will make us believe the problem is fixed, when in practice it's not for most people. We need a fallback to dymamic allocation like #53 (which was not yet merged because the code was too complicated and fragile.)

@jcorporation jcorporation deleted the buffer_size branch August 5, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants