mostly libupnp fixes

[neheb]

No description provided.

[MaxKellermann]

I don't understand the patch "upnp: fix compilation with libnpupnp". Your commit message doesn't explain the problem.

[MaxKellermann]

"MPD uses strict header includes under Windows, which blows up"
This is just the library's fault and there is no pressure for MPD to work around this. I havn't ever heard of a single user using this library on Windows, and there is no CI test case for it. If anybody wants this fixed, they should contact the library maintainer, not MPD.

[neheb]

I don't understand the patch "upnp: fix compilation with libnpupnp". Your commit message doesn't explain the problem.

Mismatching () and {}

[neheb]

"MPD uses strict header includes under Windows, which blows up" This is just the library's fault and there is no pressure for MPD to work around this. I havn't ever heard of a single user using this library on Windows, and there is no CI test case for it. If anybody wants this fixed, they should contact the library maintainer, not MPD.

It is. I reported to npupnp. It was fixed there. pupnp is left but it seems dead upstream.

edit: added PR anyway: pupnp/pupnp#436

[neheb]

msys2 CI: https://github.com/neheb/MPD/tree/mm

note the stuff I disabled since it doesn't build (mostly wchar vs char issues).

[MaxKellermann]

msys2 CI: https://github.com/neheb/MPD/tree/mm

Uh, there are tons of errors from system headers. How is that possible? I don't think MPD should aim to support such a target.

[neheb]

@MaxKellermann just looked at it. The only thing I see is the iphlapi.h include from lib(np)upnp causing issues because of MPD's lightweight header defines. Unless you mean something else.

[neheb]

@MaxKellermann fixed. New commits added.

https://github.com/neheb/MPD/actions/runs/7373340642/job/20062431237