Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set minimum meson_version to 0.63.0 #1936

Closed
wants to merge 1 commit into from
Closed

Set minimum meson_version to 0.63.0 #1936

wants to merge 1 commit into from

Conversation

jcorporation
Copy link
Member

Fixes following warning:
WARNING: Project specifies a minimum meson_version '>= 0.56.0' but uses features which were added in newer versions:

  • 0.63.0: {'Wrap files with diff_files'}

@naglis
Copy link
Contributor

naglis commented Dec 23, 2023

Looks like the build workflow needs to be updated:

The Meson version requirement is also mentioned in the documentation, so would be good to update it as well.

@jcorporation
Set minimum meson_version to 0.63.0
d316d77 
Fixes following warning:
WARNING: Project specifies a minimum meson_version '>= 0.56.0' but uses features which were added in newer versions:
 * 0.63.0: {'Wrap files with diff_files'}
@MaxKellermann
Copy link
Member

I'm not sure if we should do this - it means it's not any longer possible to build MPD with Ubuntu LTS (Meson 0.61), doesn't it?
I mean, it's possible to build MPD without any of the Meson wraps, and Meson 0.63 is only necessary to build those wraps. We shouldn't do this just to shut up a Meson warning if it means we break the build for people who don't need that feature.

@jcorporation
Copy link
Member Author

I didn’t take this into account.

@jcorporation jcorporation deleted the meson_version branch May 12, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcorporation @naglis @MaxKellermann