output/alsa: handle recoverable errors in DrainInternal() #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your commit message is lacking. It describes roughly what the patch does but not why and why it is necessary. It is not possible for me to understand your work without a proper explanation. |
It is possible that an underrun may occur in the ALSA output device while MPD is draining its own internal buffer. If this happens then MPD stops playback, reporting the error EPIPE. This commit attempts to recover the ALSA device instead of stopping playback, so that the drain can complete and the next song in the play queue is played.
It is not possible to prepare an ALSA device when it is is state SND_PCM_STATE_OPEN; it is necessary to set the hardware parameters first. This pedantic commit corrects that error. Note that in practice this code path cannot be encountered because MPD always sets the hardware parameters before attempting to start playback.
borine
force-pushed
the
alsa-drain-recovery
branch
from
064f6fa to
b1f28d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1874