-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "added" timestamp to song database #1875
Add "added" timestamp to song database #1875
Conversation
9ae5129
to
c800010
Compare
|
0c7bc17
to
6162fc0
Compare
I don't quite get it. Why is it initialized with mtime? If it's the mtime, what's the point of having a separate field, because we already have mtime? |
i initiailize it with mtime and leave it untouched in further database updates. Idea is to have a timestamp that does not change after a song was added to the database. mtime changes on each change if the file, even only a tag is corrected. With addtime there is a timestamp a mpd client can use to sort by date added and not only last modified. |
Do people really modify the song files, and is that important enough to add global unavoidable overhead to the protocol, MPD's memory consumption and to the database? |
Yes, I change tags regularly, if I see that a file was tagged falsely. Typo in a tag etc. Without the added attribute you can not get a list of newly added songs, only a list of last modified songs. We can initialize the added with the current timestamp, then the behavior is as documented. |
We shouldn't design a feature to match documentation, we should rather decide which value is more useful and then fix both code and documentation. |
I think the real added date to the mpd database is the most useful one. Would you principally merge this pull request or do you mean this is not a useful feature? I will use this feature in my mpdclient myMPD and issue #378 requests this feature also. Edit: added is now initialized with the current timestamp. |
6162fc0
to
ac54c44
Compare
- added is set to current time, if a new song is added to the database. - GetAdded falls back to mtime. Code for proxy plugin is missing, this needs a patch for libmpdclient. closes MusicPlayerDaemon#378
ac54c44
to
7bf43a9
Compare
addedtime is only set to mtime, if a new song is added to the database.
Code for proxy plugin is missing, this needs a patch for libmpdclient.
closes #378